Partial Parsing support for function nodes #12074
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12074 +/- ##
==========================================
- Coverage 91.95% 89.89% -2.07%
==========================================
Files 203 203
Lines 24833 24866 +33
==========================================
- Hits 22836 22354 -482
- Misses 1997 2512 +515
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
gshank
approved these changes
Oct 6, 2025
| source_file.nodes.remove(function_unique_id) | ||
|
|
||
| # schedule function for parsing. | ||
| # Note: We _don't_ need to schedule referencing nodes for reparsing, because a change in a function changes nothing |
There was a problem hiding this comment.
If the number of parameters has changed, is that something that's detected at parse time? Or only compilation time? If it's detected at parse time, then we should schedule referencing nodes in order to get that error. If it's not detected at parse time, this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12072
Problem
Functions previously broke if they were included during partial parsing 🫠
Solution
Plumb functions through partial parsing! 🚀
Checklist