-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add missing return statement to RuntimeConfigObject.meta_require method #12289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12289 +/- ##
==========================================
- Coverage 91.31% 91.29% -0.02%
==========================================
Files 203 203
Lines 25018 25019 +1
==========================================
- Hits 22845 22842 -3
- Misses 2173 2177 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Thank you for spotting this issue and contributing a fix so promptly @mjsqu ! The changes look good beyond a the code quality check which will require installing & running pre-commit. Additionally, we started requiring commits with verified signatures a few months ago. Unfortunately, we need to get the commits of this PR signed before we can proceed 😞 If you don't have a GPG key already github has guides Generating a new GPG key |
|
Thank you @MichelleArk - I saw the "Commits must have verified signatures" prompt, but was unable to find good advice on how to do that to existing commits - I'll have a read of your message and stackoverflow link and get myself prepped for this in future. Glad to have helped! 😃 |
Resolves #12288
Problem
config.meta_requirealways returns NoneSolution
Adds omitted return statement to have
config.meta_requirereturn the config.meta value requestedChecklist