Skip to content

Conversation

@mjsqu
Copy link

@mjsqu mjsqu commented Dec 17, 2025

Resolves #12288

Problem

config.meta_require always returns None

Solution

Adds omitted return statement to have config.meta_require return the config.meta value requested

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Dec 17, 2025
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mjsqu mjsqu marked this pull request as ready for review December 17, 2025 01:24
@mjsqu mjsqu requested a review from a team as a code owner December 17, 2025 01:24
@github-actions github-actions bot added the community This PR is from a community member label Dec 17, 2025
@MichelleArk MichelleArk reopened this Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.29%. Comparing base (2308179) to head (06ed1b0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12289      +/-   ##
==========================================
- Coverage   91.31%   91.29%   -0.02%     
==========================================
  Files         203      203              
  Lines       25018    25019       +1     
==========================================
- Hits        22845    22842       -3     
- Misses       2173     2177       +4     
Flag Coverage Δ
integration 88.10% <100.00%> (-0.02%) ⬇️
unit 65.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.25% <0.00%> (-0.01%) ⬇️
Integration Tests 88.10% <100.00%> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichelleArk
Copy link
Contributor

Thank you for spotting this issue and contributing a fix so promptly @mjsqu ! The changes look good beyond a the code quality check which will require installing & running pre-commit.

Additionally, we started requiring commits with verified signatures a few months ago. Unfortunately, we need to get the commits of this PR signed before we can proceed 😞

If you don't have a GPG key already github has guides

Generating a new GPG key
Adding a GPG key to your GitHub account
Tell the git CLI about your GPG key
And then here is a stackoverflow about how to sign all commits on a branch: https://stackoverflow.com/a/41883164

@MichelleArk
Copy link
Contributor

MichelleArk commented Dec 17, 2025

@mjsqu - We're cutting a dbt-core rc patch today, and in the interest of getting this released sooner, I'll take it over the finish line 🏁 in #12294. I've made sure you'll still get credit in the changelog though!

@mjsqu
Copy link
Author

mjsqu commented Dec 17, 2025

Thank you @MichelleArk - I saw the "Commits must have verified signatures" prompt, but was unable to find good advice on how to do that to existing commits - I'll have a read of your message and stackoverflow link and get myself prepped for this in future. Glad to have helped! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes community This PR is from a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] meta_require implementation incomplete - missing return statement

2 participants