Skip to content

Conversation

@alexaustin007
Copy link

@alexaustin007 alexaustin007 commented Jan 11, 2026

Resolves #12327

Problem

When users define BigQuery sources with dataset/project at the top level (valid aliases for schema/database), dbt-core emits a false PropertyMovedToConfigDeprecation warning stating the property should be moved into config. This regression appeared after #12291 introduced alias-aware JSON schema validation.

Solution

Add a scoped guard in JSON schema validation to treat dataset and project as valid top-level source aliases when the active adapter includes BigQuery, preventing the incorrect deprecation warning. The guard only applies to sources[] paths, so other objects and adapters continue to warn appropriately. Added unit coverage for BigQuery source alias cases and a non‑BigQuery control.

Checklist

  • [ X] I have read the contributing guide and understand what's expected of me.
  • [ X] I have run this code in development, and it appears to resolve the stated issue.
  • [X ] This PR includes tests, or tests are not required or relevant for this PR.
  • [X ] This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@alexaustin007 alexaustin007 requested a review from a team as a code owner January 11, 2026 06:00
@cla-bot
Copy link

cla-bot bot commented Jan 11, 2026

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @alexaustin007

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community This PR is from a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Warning about dataset that should be under config for sources

1 participant