Flip default for require_all_warnings_handled_by_warn_error to true #12338
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12162
Problem
The flag
require_all_warnings_handled_by_warn_errorwas introduced with a default value offalsefor backward compatibility. As per issue #12162, we need to flip the default totruefor the v1.12 milestone to ensure all warnings are properly handled by warn-error configurations.Solution
Changed the default value of
require_all_warnings_handled_by_warn_errorfromFalsetoTrueincore/dbt/contracts/project.py.This is a straightforward boolean flip. Existing tests explicitly set both
trueandfalsevalues, so no test modifications were needed. All unit tests pass (1540 tests) and code quality checks pass.Users who need the old behavior can explicitly set
require_all_warnings_handled_by_warn_error: falsein theirdbt_project.ymlfile.Checklist