Skip to content

Conversation

@Fury0508
Copy link

Resolves #12162

Problem

The flag require_all_warnings_handled_by_warn_error was introduced with a default value of false for backward compatibility. As per issue #12162, we need to flip the default to true for the v1.12 milestone to ensure all warnings are properly handled by warn-error configurations.

Solution

Changed the default value of require_all_warnings_handled_by_warn_error from False to True in core/dbt/contracts/project.py.

This is a straightforward boolean flip. Existing tests explicitly set both true and false values, so no test modifications were needed. All unit tests pass (1540 tests) and code quality checks pass.

Users who need the old behavior can explicitly set require_all_warnings_handled_by_warn_error: false in their dbt_project.yml file.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

- Changed default from false to true in core/dbt/contracts/project.py
- Added changelog entry for issue dbt-labs#12162
@Fury0508 Fury0508 requested a review from a team as a code owner January 12, 2026 00:19
@cla-bot
Copy link

cla-bot bot commented Jan 12, 2026

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @Fury0508

@github-actions github-actions bot added the community This PR is from a community member label Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community This PR is from a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flip default require_all_warnings_handled_by_warn_error to true

1 participant