fix failing tests after macro msg change#12506
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tauhid621
left a comment
There was a problem hiding this comment.
Looks good. Not sure if the dependencies should be modified for the message.
|
Should we also update the exception here dbt-core/core/dbt/exceptions.py Line 498 in d3cb077 |
0475e79 to
557f140
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12506 +/- ##
==========================================
- Coverage 91.38% 91.33% -0.06%
==========================================
Files 203 203
Lines 25455 25455
==========================================
- Hits 23263 23250 -13
- Misses 2192 2205 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
@tauhid621 The exception message was changed for |
(cherry picked from commit 3be1512)
* added implementation's first iteration * Enforce dimensions have 'validity_params' only if they have granularity (#12473) * Enforce dimensions have 'validity_params' only if they have granularity * Add enforcement for derived dimensions, too * Add changie file. * fix failing tests after macro msg change (#12506) * add uninstalled package test case * added changelog * added missing test cases and handling of missing lock yaml * better exception msg --------- Co-authored-by: Patrick Yost <159199360+theyostalservice@users.noreply.github.com>
Resolves #
Problem
The message was revised in this PR but the corresponding test assertions were not changed in dbt-core.
Solution
Change the assertion messages to new message.
Checklist