Skip to content

fix failing tests after macro msg change#12506

Merged
ash2shukla merged 1 commit intomainfrom
ash2shukla/fix/dup-macros-error-message
Feb 18, 2026
Merged

fix failing tests after macro msg change#12506
ash2shukla merged 1 commit intomainfrom
ash2shukla/fix/dup-macros-error-message

Conversation

@ash2shukla
Copy link
Contributor

Resolves #

Problem

The message was revised in this PR but the corresponding test assertions were not changed in dbt-core.

Solution

Change the assertion messages to new message.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@ash2shukla ash2shukla requested a review from a team as a code owner February 18, 2026 09:42
@cla-bot cla-bot bot added the cla:yes label Feb 18, 2026
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

@tauhid621 tauhid621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not sure if the dependencies should be modified for the message.

@tauhid621
Copy link

Should we also update the exception here

class DuplicateMacroNameError(CompilationError):

@ash2shukla ash2shukla force-pushed the ash2shukla/fix/dup-macros-error-message branch from 0475e79 to 557f140 Compare February 18, 2026 09:45
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.33%. Comparing base (d3cb077) to head (557f140).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12506      +/-   ##
==========================================
- Coverage   91.38%   91.33%   -0.06%     
==========================================
  Files         203      203              
  Lines       25455    25455              
==========================================
- Hits        23263    23250      -13     
- Misses       2192     2205      +13     
Flag Coverage Δ
integration 88.12% <ø> (-0.12%) ⬇️
unit 65.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.10% <ø> (ø)
Integration Tests 88.12% <ø> (-0.12%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ash2shukla
Copy link
Contributor Author

ash2shukla commented Feb 18, 2026

Should we also update the exception here

class DuplicateMacroNameError(CompilationError):

@tauhid621 The exception message was changed for DuplicateMacroInPackageError this is raised in parse time. L498 as per my understanding is compile time so they are independent. If we want to change the message it should be in a separate PR.

@ash2shukla ash2shukla merged commit 3be1512 into main Feb 18, 2026
122 checks passed
@ash2shukla ash2shukla deleted the ash2shukla/fix/dup-macros-error-message branch February 18, 2026 10:14
github-actions bot pushed a commit that referenced this pull request Feb 18, 2026
ash2shukla added a commit that referenced this pull request Feb 18, 2026
* added implementation's first iteration

* Enforce dimensions have 'validity_params' only if they have granularity (#12473)

* Enforce dimensions have 'validity_params' only if they have granularity

* Add enforcement for derived dimensions, too

* Add changie file.

* fix failing tests after macro msg change (#12506)

* add uninstalled package test case

* added changelog

* added missing test cases and handling of missing lock yaml

* better exception msg

---------

Co-authored-by: Patrick Yost <159199360+theyostalservice@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments