Add snapshot unique_key hint for duplicate row errors#12983
Open
desusaiteja wants to merge 2 commits into
Open
Add snapshot unique_key hint for duplicate row errors#12983desusaiteja wants to merge 2 commits into
desusaiteja wants to merge 2 commits into
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @desusaiteja |
03f5356 to
f23c06c
Compare
…apshot-unique-key-hint # Conflicts: # core/dbt/task/snapshot.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10864
Problem
When a snapshot
unique_keyis not actually unique, some adapters return a genericDuplicate row detected during DML actionerror. The existing message does not point users toward the likely root cause, which makes a straightforward snapshot configuration issue harder to diagnose.Solution
Append a snapshot-specific hint when snapshot execution surfaces the duplicate-row DML error. The new hint points users to the likely problem: the configured
unique_keyis not unique in the snapshot query.This PR adds:
SnapshotRunner.handle_exceptionoverride that appends the hint only for the duplicate-row DML error message.SnapshotRunner.handle_exception.I also ran the change in development and verified the local Postgres path. Postgres did not naturally reproduce this adapter-specific error, so the adapter-specific branch is covered via the mocked runner test.
Checklist