feat(redshift): make partition vals optional for redshift external tables#364
Open
nitish-raj wants to merge 1 commit intodbt-labs:mainfrom
Open
feat(redshift): make partition vals optional for redshift external tables#364nitish-raj wants to merge 1 commit intodbt-labs:mainfrom
nitish-raj wants to merge 1 commit intodbt-labs:mainfrom
Conversation
… absent; add integration test;
Author
|
@jeremyyeo Could you please take a look at this PR. It is quite important and fixes a major blocker for external tables setup in Redshift. Also looks like the snowflake integration test is failing due to access issue, also highlighted in another PR. Thank you. |
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
Redshift Spectrum doesn’t require partitions to be registered at table-create time. Many users register partitions later via Glue/Athena/event-driven flows. Forcing
valsleads to brittle date math or references to partition values that do not exist, and it causes failures whenvalsare omitted.Changes
valsoptional for Redshift duringstage_external_sources.vals, generateALTER TABLE … ADD PARTITION(unchanged).vals, skip only the partition-registration DDL; table creation and partition columns remain unchanged.User-visible behavior
vals→ error ('dict object' has no attribute 'vals').vals→ succeeds; no partition DDL is emitted. Existing partitions remain unchanged.Checklist