Skip to content

Add property: "delimiter" in seed-config#171

Open
kouta-fujimura wants to merge 2 commits intodbt-labs:mainfrom
kouta-fujimura:add-delimiter
Open

Add property: "delimiter" in seed-config#171
kouta-fujimura wants to merge 2 commits intodbt-labs:mainfrom
kouta-fujimura:add-delimiter

Conversation

@kouta-fujimura
Copy link

https://docs.getdbt.com/reference/resource-configs/delimiter

dbt supports delimiter from v1.7, but currenly not exists in two files.

  • dbt_project.json
  • dbt_yml_files.json

Copy link
Contributor

@dave-connors-3 dave-connors-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @kouta-fujimura ! thanks for the PR -- generally we are only amending the jsonschemas under the latest/ directory, but since you did the work here, I'm happy to merge these in to 1.7 as well!

It looks like we'll need to also edit latest/dbt_project-latest.json to make sure there's support for delimiter there as well. Additionally, if you could revert the change to the dbt_project.json at the root of the repo, that would be great! those are legacy files that we don't update.

@kouta-fujimura
Copy link
Author

@dave-connors-3
thank you for the review !
sorry, I had mistakenly mixed up /dbt_project.json and /latest/dbt_project-latest.json, so I added a commit to fix it (Additionally, I have added a property without plusses for CI).

@Phil-Garmann
Copy link

Any progress on this PR? 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants