Less tab storms through smarter failures#15
Merged
Conversation
When a failure that isn't retryable happens, fail fast. Proved this design is still self healing mid execution (opens another tab) or upon next invocation (opens another SAML window).
jasonlin45
approved these changes
Sep 4, 2025
VersusFacit
commented
Sep 4, 2025
|
|
||
| // Quality of life features for externalbrowser | ||
| var lastFail sync.Map // key -> time.Time (expiry) | ||
| const extBrowserBackoffWindow = 10 * time.Second |
Author
There was a problem hiding this comment.
I'm actually thinking I might bump this back up to 30 since we want to fast fail all threads waiting to auth once the first failure is discovered and 10 seconds may not be enough...
felipecrv
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I made a finite state machine 🫠
I manually ran through the behaviors I changed and can report the mysterious (why are all these SAMLs continuously spamming even though my first auth failed / was cancelled) scenario is fast failing now.
External Browser Authentication Failure Scenarios
authenticateByExternalBrowserauthenticate()authenticate(). Underlying error surfaces if refresh fails.Manual tests using
buildin a dbt project