Skip to content

Fix order items data #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rossbowen
Copy link

Hey! Great project!

Running jafgen off the latest commit doesn't return order item data as expected - instead the data produced are copies of the different products.

I've reintroduced order items throughout with some slight changes to the codebase:

  • Added OrderItem in order.py and changed the get_order_items return type for each of the customer personas.
  • Order items now have a quantity field, indicating a customer can order multiples of a particular product.
  • I've renamed Item to Product throughout to distinguish between a product-item and an order-item.

@rossbowen rossbowen requested a review from a team as a code owner May 18, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant