Skip to content

Migrate job data source from sdkv2 to fw sign 30#380

Merged
adrianburusdbt merged 13 commits intomainfrom
migrate-jobs-from-sdkv2-to-fw-sign-30
Apr 8, 2025
Merged

Migrate job data source from sdkv2 to fw sign 30#380
adrianburusdbt merged 13 commits intomainfrom
migrate-jobs-from-sdkv2-to-fw-sign-30

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 3, 2025

Summary: Migrate data resource related to job from SDKv2 to Framework.

Changes:

  • Translated code from SDKv2 to Framework provider
  • Updated SDKv2 & Framework provider
  • Removed files from SDKv2
  • Added deprecated for fields that were moved or renamed

Testing: Moved existing tests that targeted the SDKv2 versions to their respective places in the Framework destination.

Checklist:

  • Followed the structure of other existing data sources/ resources
  • Tests pass
  • Manual testing

Changes to the models after migrating to framework (Followed the model from data_source_all.go

SDKV2 job Framework job Note
  Id  
project_id project_id  
environment_id environment_id  
name name  
description description  
job_id job_id  
deferring_job_id deferring_job_definition_id seem to be the same field from job, added deprecated to deferring_job_id
deferring_environment_id deferring_environment_id  
self_deferring  self_deferring  
triggers triggers.github_webhook, triggers.git_provider_webhook, triggers.schedule, triggers.on_merge  
timeout_seconds execution.timeout_seconds  kept both and added deprecated to timeout_seconds
triggers_on_draft_pr triggers_on_draft_pr  
job_completion_trigger_condition job_completion_trigger_condition  
run_compare_changes run_compare_changes  
  run_generate_sources  
  generate_docs  
  dbt_version  
  execute_steps  
  settings (threads, target_name)  
  schedule (cron)  
  job_type  
  environment For get all jobs

Comment thread pkg/framework/objects/job/schema.go
@ghost ghost marked this pull request as ready for review April 7, 2025 11:45
@ghost ghost self-requested a review as a code owner April 7, 2025 11:45
@ghost ghost requested review from b-per and chasewalden April 7, 2025 11:46
@adrianburusdbt adrianburusdbt merged commit 9e3e9bf into main Apr 8, 2025
5 checks passed
@adrianburusdbt adrianburusdbt deleted the migrate-jobs-from-sdkv2-to-fw-sign-30 branch April 8, 2025 11:41
victorasu added a commit that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants