Handle resource removal from state if resource not found #604
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorasu
approved these changes
Jan 14, 2026
Contributor
victorasu
left a comment
victorasu
left a comment
There was a problem hiding this comment.
I think we should have this handling on all other resources too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds proper resource-not-found error handling to dbtcloud_semantic_layer_credential_service_token_mapping resource's Read() function, consistent with other semantic layer resources fixed in #597.
Changes
When the API returns "resource-not-found", the resource is now gracefully removed from state with a warning instead of failing with an error
This aligns with standard Terraform patterns for handling resources deleted out-of-band