spike: explore dbt Core 1.12 v2 parser support (fixes #770) - #782
Draft
axellpadilla wants to merge 1 commit into
Draft
spike: explore dbt Core 1.12 v2 parser support (fixes #770)#782axellpadilla wants to merge 1 commit into
axellpadilla wants to merge 1 commit into
Conversation
- add dbt-core 1.12.0 + dbt-core-experimental-parser>=2.0.0a5 dev dep - add v2-parser-tests CI job (blocking, push/PR only) - add 13 xfail tests: parse, compile, build, docs generate, adapter features - add devops/scripts/compare_manifests.py for v1 vs v2 manifest diffing - add docs/contributing/v2-parser.md with finding: sqlserver not yet supported - add make v2-parser-test target Finding: v2 parser rejects type=sqlserver in profiles.yml. All tests xfail strict=True -- will auto-pass when upstream adds sqlserver adapter support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigation and infrastructure for dbt Core 1.12
--use-v2-parsersupport with thedbt-sqlserveradapter. Closes #770.Finding
The v2 parser (
dbt-core-experimental-parser2.0.0-alpha.5 / dbt Fusion) does NOT recognize thesqlserveradapter type. Its profiles.yml validation rejectstype: sqlserveras an unknown variant. Untilsqlserveris added to the v2 parser's adapter registry,--use-v2-parsercannot be used withdbt-sqlserver.What's included
dbt-core-experimental-parser>=2.0.0a5(dev dep)v2-parser-testsjob in integration workflow. Blocking, push/PR only.xfail(strict=True)pending upstream supportdevops/scripts/compare_manifests.pyfor v1 vs v2 manifest diffsdocs/contributing/v2-parser.md-- status, references to source code, local setupmake v2-parser-testtargetWhat happens when upstream adds sqlserver
All 13
xfailmarkers arestrict=True. The momentdbt-core-experimental-parseraddssqlserverto its adapter enum, the test suite flips from expected-fail to expected-pass -- no code changes needed. Remove thexfaildecorators and it's done.Test output
References
--use-v2-parserflag (#13029)dbt/cli/params.pylines 805-818: flag definition, default binary pathdbt/parser/fusion.py: handoff logic spawning v2 parser subprocess