Skip to content

PhotoExibition #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

PhotoExibition #21

wants to merge 5 commits into from

Conversation

@jmtannus
Copy link

@jmtannus jmtannus commented May 9, 2024 •
edited
Loading

Objetivo: Criar o componente para importar a imagem da foto do gato do usuário. Deve ter um botão de remover a imagem logo abaixo da moldura.

Closes #10
#10 (comment)

Online at: https://6634f18d79a7835323a8328c-dzvuihqhwz.chromatic.com/?path=/story/components-photoexibition--primary

@jmtannus jmtannus self-assigned this May 9, 2024
@jmtannus jmtannus marked this pull request as draft May 9, 2024 02:48
@jmtannus jmtannus changed the title Photo-exibition PhotoExibition May 9, 2024
@jmtannus jmtannus linked an issue May 9, 2024 that may be closed by this pull request
Photo Exibition (Cat) #10
Open
@jmtannus jmtannus added bug Something isn't working wontfix This will not be worked on and removed bug Something isn't working labels May 9, 2024
@AbraaoAlves
Copy link
Contributor

AbraaoAlves commented May 9, 2024

@jmtannus
Remember:

  • you don't need to change home.jsx page component
  • you need to create a stories file for your new component (see others PRs as example)

@AbraaoAlves AbraaoAlves removed the wontfix This will not be worked on label May 10, 2024
@jmtannus jmtannus marked this pull request as ready for review May 10, 2024 13:35
@jmtannus jmtannus requested a review from AbraaoAlves May 10, 2024 13:36
teusgomes
teusgomes requested changes May 10, 2024
View reviewed changes
Copy link

@teusgomes teusgomes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Corrigir também o upload da imagem. Testei e não funcionou.

  • Acredito que em aspecto de design, poderiamos ter algum contraste para melhor visualização. Talvez colocar as bordas da imagem mais escura. Segue a issue em comparação com a aplicação no storybook:

image
image

jmtannus
jmtannus commented May 17, 2024
View reviewed changes
Copy link
Author

@jmtannus jmtannus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito obrigada! Verei qual é a cor padrão e alterarei.

@jmtannus jmtannus requested a review from teusgomes May 20, 2024 22:11
@jmtannus
Copy link
Author

jmtannus commented May 20, 2024

  • Corrigir também o upload da imagem. Testei e não funcionou.
  • Acredito que em aspecto de design, poderiamos ter algum contraste para melhor visualização. Talvez colocar as bordas da imagem mais escura. Segue a issue em comparação com a aplicação no storybook:

image image

Oi Matheus, aqui eu não implementei o upload da imagem, só a parte gráfica. Não era pra funcionar mesmo. Irá funcionar quando estiver integrado à pasta. Obrigada pela observação

jmtannus
jmtannus commented May 20, 2024
View reviewed changes
Copy link
Author

@jmtannus jmtannus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbraaoAlves AbraaoAlves Awaiting requested review from AbraaoAlves

@teusgomes teusgomes Awaiting requested review from teusgomes

Requested changes must be addressed to merge this pull request.

Assignees

@jmtannus jmtannus

@jv-farias jv-farias

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Photo Exibition (Cat)

5 participants

@jmtannus @AbraaoAlves @teusgomes @jv-farias