feat(nvue-styler): 调整 uvue 中 flex-flow 拆分、支持 ::v-deep #5495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the flex-flow transform is applied in uvue and updates the corresponding tests to reflect splitting flexFlow into flexDirection and flexWrap.
- Always include
transformFlexFlowfor uvue (removed conditional guard) - Rename test properties from
flexFlowtoflex-flowand expect separateflexDirection/flexWrap - Adjust test case counts and message indices
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/uni-nvue-styler/src/expand/index.ts | Removed the options.type !== 'uvue' guard so transformFlexFlow always applies |
| packages/uni-nvue-styler/tests/uvueNormalize-android.spec.ts | Updated CSS property names in tests and expanded flexFlow split; adjusted message indices and added length check |
Comments suppressed due to low confidence (2)
packages/uni-nvue-styler/src/expand/index.ts:52
- Add a comment explaining why
transformFlexFlowis now always applied (even for uvue) to clarify the removal of the conditional spread.
flexFlow: transformFlexFlow,
packages/uni-nvue-styler/tests/uvueNormalize-android.spec.ts:505
- Consider adding an assertion that the normalized output object contains both
flexDirectionandflexWrapproperties after splittingflexFlowto ensure the transform works as intended.
flexDirection: 'row',
Size report
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances flex-flow handling in the uni-nvue-styler, especially for uvue contexts, and updates tests accordingly.
- Adds special selector normalization for
::v-deepand:deep()in uvue. - Makes
transformFlexFlowunconditional in the declaration transforms. - Updates and adds tests for flex-flow splitting into
flexDirectionandflexWrap.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/uni-nvue-styler/src/normalize/index.ts | Add uvue-specific handling for ::v-deep and :deep() selectors |
| packages/uni-nvue-styler/src/expand/index.ts | Remove conditional around flexFlow transform |
| packages/uni-nvue-styler/tests/uvueNormalize-ios.spec.ts | New tests for deep selector normalization |
| packages/uni-nvue-styler/tests/uvueNormalize-android.spec.ts | Adjust flex-flow tests to output flexDirection/flexWrap and shift error assertions |
| packages/uni-nvue-styler/tests/parse-nvue.spec.ts | Add tests for splitting flex-flow into separate properties |
Comments suppressed due to low confidence (3)
packages/uni-nvue-styler/src/normalize/index.ts:51
- Add the global flag to the regex (
/\s+/g) so that multiple whitespace sequences throughout the selector are collapsed, not just the first.
.replace(/\s+/, ' ')
packages/uni-nvue-styler/src/expand/index.ts:52
- This transform is now applied unconditionally. If
uvueshould still skipflex-flow, consider reintroducing a guard based onoptions.type.
flexFlow: transformFlexFlow,
packages/uni-nvue-styler/src/normalize/index.ts:36
- Add a test case where a selector contains multiple
::v-deepor:deep()patterns to verify that all instances are correctly normalized.
const isUvue = opts.type === 'uvue'
Otto-J
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts flex‐flow splitting for uvue styling in the uni-nvue-styler package by refining deep selector handling and unconditionally applying the flexFlow transformation. Key changes include:
- In the normalize module, deep selector replacements for ::v-deep and :deep() are applied when opts.type is 'uvue'.
- In the expand module, the conditional check for uvue has been removed so that flexFlow is now always applied.
- New test cases have been added to verify the updated behavior across iOS, Android, and nvue modes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/uni-nvue-styler/src/normalize/index.ts | Added uvue-specific deep selector handling and whitespace normalization updates. |
| packages/uni-nvue-styler/src/expand/index.ts | Removed conditional spreading of flexFlow transformation, applying it for all types. |
| packages/uni-nvue-styler/tests/uvueNormalize-ios.spec.ts | Added tests to verify deep selector processing and border properties. |
| packages/uni-nvue-styler/tests/uvueNormalize-android.spec.ts | Updated tests to reflect changes in flex-flow property transformation and message indexing. |
| packages/uni-nvue-styler/tests/parse-nvue.spec.ts | Introduced tests for flex-flow behavior and for cases where nvue does not support deep selectors. |
Comments suppressed due to low confidence (1)
packages/uni-nvue-styler/src/expand/index.ts:50
- The removal of the conditional spread means that the flexFlow transformation is now applied unconditionally. Please add an inline comment to explain that this behavior is an intentional change for uvue styling.
flexFlow: transformFlexFlow,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.