rename dcm-ui env to DCM_API_URL#17
Merged
gabriel-farache merged 1 commit intoJun 29, 2026
Merged
Conversation
Requires dcm-ui image with apiUrl support. Part of [FLPATH-4424](https://redhat.atlassian.net/browse/FLPATH-4424) Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
requested review from
gabriel-farache,
jenniferubah and
machacekondra
as code owners
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
machacekondra
approved these changes
Jun 29, 2026
gabriel-farache
approved these changes
Jun 29, 2026
gciavarrini
added a commit
to dcm-project/quadlet-deploy
that referenced
this pull request
Jun 30, 2026
Renames the `dcm-ui` quadlet env var from `DCM_API_GATEWAY_URL` to `DCM_API_URL`, matching the control-plane monolith naming from. The URL value is unchanged (`http://control-plane:8080`). Part of [FLPATH-4424](https://redhat.atlassian.net/browse/FLPATH-4424).⚠️ **Merge order (required):**⚠️ 1. [rhdh-plugins #3603](redhat-developer/rhdh-plugins#3603) + new `dcm-ui` image 2. [control-plane #17](dcm-project/control-plane#17) 3. this PR #### Why `verify_compose_alignment.yml` is unchanged Jira lists two quadlet files, but the verify playbook does not hardcode env var names. It clones upstream `control-plane/deploy/compose.yaml` and compares compose env keys to quadlet templates at runtime. Once control-plane `main` uses `DCM_API_URL`, the existing assert covers the new name with no alias or mapping. A verify edit is only needed when PRs land out of order; we merge in sequence, so no change here. -- Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
dcm-uienvironment variable fromDCM_API_GATEWAY_URLtoDCM_API_URLin compose and Helm deploy configs, matching the control-plane monolith naming.Part of FLPATH-4424
Depends on: rhdh-plugins #3603 (merged)
Until then, deployments using the old env var still work via the plugin legacy fallback.
Follow-up: quadlet-deploy rename in dcm-project/quadlet-deploy#7.
Assisted-By: Claude (Anthropic)
Signed-off-by: Gloria Ciavarrini gciavarrini@redhat.com