Conversation
c8bacac to
5a52f86
Compare
Member
|
So awesome that you provided test and testing instructions! |
Contributor
Author
We'll I seem to struggle with the tests ;) But will mark this ready once all is passing. |
Member
|
Bats is supposed to be easy but it isn't always easy :) |
2f0f2ce to
f07813a
Compare
Member
|
Yay, congrats! |
stasadev
requested changes
Jul 21, 2025
Member
stasadev
left a comment
There was a problem hiding this comment.
Thank you!
Manual testing works well, my suggestion is to add more checks to test for each of these values in all cases.
…meters and increase
f07813a to
98e1010
Compare
stasadev
reviewed
Jul 22, 2025
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
stasadev
approved these changes
Jul 22, 2025
Member
stasadev
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
It would be nice to be able to easily adjust the varnish startup parameters.
Env-Variables are a bit more intuitive than docker compose file creation.
Further I think it would be beneficial to increase the default varnishd limits for http headers and payload sizes.
These payloads often are larger on development environments and can cause hard to track issues.
How This PR Solves The Issue
Adds a env-variable for the parameters and defines larger limits by defaiult.
Manual Testing Instructions
Automated Testing Overview
Added new test to check if customization is picked up:
bats ./tests/test.bats --filter "customize varnishd startup parameters"Release/Deployment Notes