Conversation
ad5ce16 to
60c3d54
Compare
stasadev
requested changes
Aug 5, 2025
Member
stasadev
left a comment
There was a problem hiding this comment.
Thank you!
In addition to my suggestions, please add this new command to the README.md table https://github.com/ddev/ddev-varnish#helper-commands
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
Contributor
Author
|
@stasadev Thanks for the feedback! All things should be addressed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
For rapid vcl development it would be handy to have a in-place config reloading feature for the varnish configuration.
How This PR Solves The Issue
Provides a command to achieve exactly that.
Manual Testing Instructions
Automated Testing Overview
Added a test for the command since it is a more involved one than the other "pass-through" commands.
The test just has to verify that all the handling from the
varnishadmreturns the expected outputs to verify a reload is working in "theory".Release/Deployment Notes