Skip to content

feat: Provide command to reload config in place, fixes #44#45

Merged
stasadev merged 4 commits intoddev:mainfrom
CandoImage:20250804_das_peter_44_provide-config-reload-command
Aug 5, 2025
Merged

feat: Provide command to reload config in place, fixes #44#45
stasadev merged 4 commits intoddev:mainfrom
CandoImage:20250804_das_peter_44_provide-config-reload-command

Conversation

@das-peter
Copy link
Copy Markdown
Contributor

The Issue

How This PR Solves The Issue

Provides a command to achieve exactly that.

Manual Testing Instructions

ddev add-on get https://github.com/CandoImage/ddev-varnish/archive/refs/heads/20250804_das_peter_44_provide-config-reload-command.tar.gz
ddev restart
ddev varnish-config-reload

Automated Testing Overview

Added a test for the command since it is a more involved one than the other "pass-through" commands.
The test just has to verify that all the handling from the varnishadm returns the expected outputs to verify a reload is working in "theory".

Release/Deployment Notes

@das-peter das-peter force-pushed the 20250804_das_peter_44_provide-config-reload-command branch from ad5ce16 to 60c3d54 Compare August 4, 2025 09:17
@stasadev stasadev self-requested a review August 5, 2025 10:41
Copy link
Copy Markdown
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

In addition to my suggestions, please add this new command to the README.md table https://github.com/ddev/ddev-varnish#helper-commands

das-peter and others added 3 commits August 5, 2025 13:47
@das-peter
Copy link
Copy Markdown
Contributor Author

@stasadev Thanks for the feedback! All things should be addressed now.

Copy link
Copy Markdown
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@stasadev stasadev merged commit cfeeb53 into ddev:main Aug 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants