Feature/crawl skincare#9
Merged
Merged
Conversation
…nto feature/crawl-skincare
… -> selenium 으로 수정
…nto feature/crawl-skincare
…uys/olvy-insight into feature/crawl-skincare
…nto feature/crawl-skincare
…uys/olvy-insight into feature/crawl-skincare
Member
|
PR Check 단계에서 Ruff 기반 Code Lint 형식애 맞지 않는 코드가 발견되었나 보네요. 그리고 docs/Ruff-guide.md 문서도 이전에 수정 사항이 있었는데 크롤링 feature branch에 반영이 안 된 것도 확인이 됩니다. |
…nto feature/crawl-skincare
Contributor
Author
|
ruff로 코드 형식 체크진행과 docs/Ruff-guide.md 문서 수정사항 변경 적용했습니다! |
jjunier
requested changes
Jul 10, 2025
jjunier
left a comment
Member
There was a problem hiding this comment.
.gitignore 파일 세팅이 안 되어 있었군요.. 제가 이런 실수를 하다니..
얼른 작업 후에 main으로 병합 해둘테니 잠시 PR 보류 바랄게요..
죄송합니다 🙏🙏
Contributor
Author
|
.gitignore 파일도 적용됐습니다~! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 개요
✅ PR 체크리스트
✏️ 주요 변경 사항
🧪 📷 스크린샷 or 테스트 결과 (선택)
📎 관련 이슈
close #7
close #8
💬 리뷰어에게 하고 싶은 말 (선택)