Skip to content

Conversation

@milo39
Copy link
Member

@milo39 milo39 commented Nov 6, 2025

Try to fulfill the following points before the Pull Request is merged:

  • Give a meaningfull description for the PR
  • The PR is reviewed by one of the team members.
  • If a linting PR exists, it must be merged before this PR is allowed to be merged.
  • It must be checked if anything in the Readme must be adjusted (development-, production-, setup).
  • If the requirements.txt have changed, check if the patches still work
  • It must be checked if any section in the wiki (https://simplevm.denbi.de/wiki/) should be adjusted.
  • If the PR is merged in the master then a release should be be made.
  • If the new code is readable, if not it should be well commented

For any changes of the code please consider:

  • Cover the changes with corresponding unit tests

For releases only:

  • If the review of this PR is approved and the PR is followed by a release then the .env file
    in the cloud-portal repo should also be updated.
  • If you are making a release then please sum up the changes since the last release on the release page using the clog tool with clog -F

@milo39 milo39 requested a review from dweinholz November 6, 2025 08:14
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
simple_vm_client
   VirtualMachineHandler.py2132020 91%
   __init__.py10100% 
simple_vm_client/benchmark
   __init__.py00100% 
   test_service.py523636 31%
simple_vm_client/bibigrid_connector
   __init__.py00100% 
   bibigrid_connector.py1263636 71%
   test_bibigrid_connector.py1180100% 
simple_vm_client/forc_connector
   __init__.py00100% 
   forc_connector.py3255757 82%
simple_vm_client/forc_connector/playbook
   __init__.py00100% 
   playbook.py1890100% 
   test_playbook.py3810100% 
simple_vm_client/forc_connector/template
   __init__.py00100% 
   template.py2271414 94%
simple_vm_client/metadata_connector
   metadata_connector.py1122626 77%
   test_metadata_connector.py680100% 
simple_vm_client/openstack_connector
   __init__.py00100% 
   openstack_connector.py977153153 84%
   test_openstack_connector.py124822 99%
simple_vm_client/tests
   test_virtualmachinehandler.py3150100% 
simple_vm_client/util
   __init__.py00100% 
   state_enums.py700100% 
   test_thrift_converter.py1700100% 
   thrift_converter.py8033 96%
TOTAL467234793% 

Tests Skipped Failures Errors Time
312 0 💤 1 ❌ 0 🔥 3.991s ⏱️

@dweinholz dweinholz requested review from vktrrdk and removed request for dweinholz November 21, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants