fix devcontainer failed to start#477
Conversation
| redis-sentinel: | ||
| # https://hub.docker.com/r/bitnami/redis-sentinel | ||
| image: bitnami/redis-sentinel:7.4 | ||
| image: bitnami/redis-sentinel:latest |
There was a problem hiding this comment.
Note to maintainer: this is related to bitnami/containers#83267 and using latest is the recommended way.
There was a problem hiding this comment.
I know this is recommended but I'm quite unhappy about this practice. That way things randomly break or can be fixed by a container rebuild.
With a pinned version everyone using the devcontainer will run a known good version of the images.
Co-authored-by: Simon Sawert <simon@sawert.se>
bombsimon
left a comment
bombsimon
left a comment
There was a problem hiding this comment.
I'm no maintainer nor collaborator but maybe a review will help ease load of maintainer anyway!
Nice fix! 🎉
|
Awesome. Thanks a lot. I'll look into that shortly. 👍 |
There was a problem hiding this comment.
I wonder what's the reason for adding this file. The Dockefile doesn't copy anything from the .devcontainer directory anyways so this does nothing.
| redis-sentinel: | ||
| # https://hub.docker.com/r/bitnami/redis-sentinel | ||
| image: bitnami/redis-sentinel:7.4 | ||
| image: bitnami/redis-sentinel:latest |
There was a problem hiding this comment.
I know this is recommended but I'm quite unhappy about this practice. That way things randomly break or can be fixed by a container rebuild.
With a pinned version everyone using the devcontainer will run a known good version of the images.
| RUN /home/vscode/.cargo/bin/cargo install cargo-release | ||
| RUN /home/vscode/.cargo/bin/cargo install --locked cargo-outdated |
There was a problem hiding this comment.
Why move this to the post-create step of the container? I know a lot of people use a quite vanilla container and then add things via features (or post-create scripts) but honestly I never really understood the rationale behind that.
3 participants
Fix the devcontainer failing to start in Codespaces and improve build performance.
Changes:
redis-sentinelimage tag indocker-composecargo-releaseandcargo-outdatedinstallation topostCreateCommand.dockerignoreto avoid unnecessary full Docker rebuildsCloses #476