Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-8301 Support for decimal.handling.mode #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpechane
Copy link

@jpechane jpechane commented Oct 8, 2024

Copy link

github-actions bot commented Oct 8, 2024

Hi @jpechane. Thank you for your valuable contribution.
Please author your commit(s) using an email linked to your GitHub account.

Copy link

github-actions bot commented Oct 8, 2024

Welcome as a new contributor to Debezium, @jpechane. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively.

@jpechane
Copy link
Author

jpechane commented Oct 8, 2024

@aziza-calm Would it be possible to add a test to verifythe behaviour?

@aziza-calm
Copy link

@aziza-calm Would it be possible to add a test to verifythe behaviour?

sorry for maybe silly question, but should I first clone your forked copy of repo, and add test there?

@jpechane
Copy link
Author

No, Isuppose you have a fork repo of this one. So you should just add another class side- by-side with As400ConnectorIT.
The class should have three methods. The test tbale should contain at least one decimal column. Each test method will test a different mode and verify that the schema of the message is of the expected schema type and the value is of the expected Java type and value.

@aziza-calm
Copy link

No, Isuppose you have a fork repo of this one. So you should just add another class side- by-side with As400ConnectorIT. The class should have three methods. The test tbale should contain at least one decimal column. Each test method will test a different mode and verify that the schema of the message is of the expected schema type and the value is of the expected Java type and value.

I do have a fork repo, and I did some changes on it before I noticed that my PR was closed. How to put those changes in new 2 PRs?

@jpechane
Copy link
Author

You should be able to just cherry-pick the commits you need to apply to the new branches/PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants