Skip to content

Commit

Permalink
DBZ-8564 Move away from dockerhub
Browse files Browse the repository at this point in the history
Integration tests use testcontainers Docker Compose which results into
pulling `docker/compose` image. There doesn't seem to be a way how to
force testconatiners to use different registry for this image, the only
thing which seems to work is setting up env. variable
`TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX`, which would result into pulls
from dockerhub when e.g. building it manually wihtout setting this
variable, but this is probably not a big issue. At least CI should avoid
using dockerhub, as `TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX` is now set in
GH actions.
  • Loading branch information
vjuranek authored and jpechane committed Jan 21, 2025
1 parent 82ab0ca commit caa244b
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Maven build debezium core
run: mvn clean install -f core/pom.xml -pl debezium-bom,debezium-core,debezium-embedded,debezium-storage -am -DskipTests -DskipITs -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
- name: Maven Package spanner connector core
run: mvn -B clean install
run: TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX=mirror.gcr.io/ mvn -B clean install
# - name: Maven unit tests
# run: mvn test --batch-mode -Dmaven.test.failure.ignore=true
# # Tests report
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Maven build debezium core
run: mvn clean install -f core/pom.xml -pl debezium-bom,debezium-core,debezium-embedded,debezium-storage -am -DskipTests -DskipITs -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
- name: Maven build connector core
run: mvn -B clean install
run: TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX=mirror.gcr.io/ mvn -B clean install
## Add your DockerHub credantials to Aithub Actions
## secrets.DOCKER_USERNAME = username
## secrets.DOCKER_PASSWORD = usertoken
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Maven build debezium core
run: mvn clean install -f core/pom.xml -pl debezium-bom,debezium-core,debezium-embedded,debezium-storage -am -DskipTests -DskipITs -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
- name: Maven Package spanner connector core
run: mvn -B clean install
run: TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX=mirror.gcr.io/ mvn -B clean install
## Tests report
- name: Report
uses: dorny/test-reporter@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cross-maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,4 @@ jobs:
- name: Maven build core
run: ./spanner/mvnw clean install -f core/pom.xml -pl debezium-bom,debezium-core,debezium-embedded,debezium-storage -am -DskipTests -DskipITs -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
- name: Maven build Spanner
run: ./spanner/mvnw clean install -f spanner/pom.xml -Passembly -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
run: TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX=mirror.gcr.io/ ./spanner/mvnw clean install -f spanner/pom.xml -Passembly -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ jobs:
- name: Build Debezium Core
run: ./spanner/mvnw clean install -f core/pom.xml -pl debezium-bom,debezium-core,debezium-storage -am -DskipTests -DskipITs -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
- name: Build Debezium Connector Spanner
run: ./spanner/mvnw clean install -f spanner/pom.xml -Passembly -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
run: TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX=mirror.gcr.io/ ./spanner/mvnw clean install -f spanner/pom.xml -Passembly -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120

0 comments on commit caa244b

Please sign in to comment.