Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-8715 Added message compression and concurrency control #157

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

nathan-smit-1
Copy link
Contributor

Hi there,

Made adjustments to include concurrency and compression to pub/sub:

https://cloud.google.com/pubsub/docs/concurrency-control-messages
https://cloud.google.com/pubsub/docs/compress-messages

Set the default concurrency threads to 1 as I imagine anyone setting concurrency to true has some specific goal in mind and will almost certainly adjust. The compression threshold I set is the default value as per the docs.

@nathan-smit-1
Copy link
Contributor Author

I'm not sure what this build failure is but I'm seeing it on some of the other pull requests as well

@jpechane
Copy link
Contributor

@nathan-smit-1 Thanks for the PR. I wonder if in both cases do we need the enabled config option. Maybe if we introduce 0 as a special value for number of threads and -1 for compression threshold then we could use them as enabled/disabled flag. This would reduce the total number of config options. WDYT?

@nathan-smit-1
Copy link
Contributor Author

@nathan-smit-1 Thanks for the PR. I wonder if in both cases do we need the enabled config option. Maybe if we introduce 0 as a special value for number of threads and -1 for compression threshold then we could use them as enabled/disabled flag. This would reduce the total number of config options. WDYT?

@jpechane I think that makes sense. Are you okay with the implementation I just pushed with just the two configs? I also updated documentation on this pull: debezium/debezium#6176

@jpechane jpechane merged commit 3f46add into debezium:main Feb 25, 2025
2 checks passed
@jpechane
Copy link
Contributor

@nathan-smit-1 Applied, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants