debezium/dbz#1470 Fix JWTAuthenticatorTest + slight refactor #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes debezium/dbz#1470
Initial I thought I had broken JWTAuthenticatorTest with my PR but it failed already before that.
I fixed the tests, and did some slight refactors.
Before the refreshEndpoint called the "authenticate" endpoint instead. (it used the
authRequestBuilderisorefreshRequestBuilderThe public API has slightly changed with
authenticatebut I assume there is no requirement to keep it backwards compatible.Also in
recordSentIOException is wrapped into a interrupt? There is test for this. So I have kept it. But imo this doesn't make sense. IOException should just be failure. (connection broke) so that the retry system can catch this. Iso propagating up as an interrupt.The HttpIT tests still don't work. But i'll probably fix those too. Then I am probably going to add better concurrency options to this sink bc the current setup; Is a sequential blocking implementation. And If you have 5ms time per request you can only send at 200/s.
Also, where can you see the "hash" of the nightly build. I tried with nightly of yesterday but I could still repro the issue.