Skip to content

Clarify manual sharding for forks in runCypress function #7743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinjagodic merged 3 commits into from
Mar 5, 2026
+4 −6
Merged

Clarify manual sharding for forks in runCypress function #7743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e2a04a
fix(cypress): clarify manual sharding for forks in runCypress function
martinjagodic Mar 5, 2026
91e815f
Merge branch 'main' into fix-cypress-fork
martinjagodic Mar 5, 2026
0307c73
fix(cypress): enable fail-fast strategy for E2E tests and remove auto…
martinjagodic Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
if: ${{ needs.changes.outputs.cms == 'true' }}
runs-on: ubuntu-latest
strategy:
fail-fast: false # Let Cypress Cloud auto-cancellation handle failures
fail-fast: true
matrix:
machine: [1, 2, 3, 4]
steps:
Expand Down
8 changes: 3 additions & 5 deletions cypress/run.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ async function runCypress() {

const machineIndex = Number(process.env.MACHINE_INDEX || 0);
const machineCount = Number(process.env.MACHINE_COUNT || 0);
const isFork = process.env.IS_FORK === 'true';

if (machineIndex && machineCount) {
if (isFork && machineIndex && machineCount) {
const specsPerMachine = Math.floor(specs.length / machineCount);
const start = (machineIndex - 1) * specsPerMachine;
const machineSpecs =
Expand All @@ -22,7 +23,7 @@ async function runCypress() {
: specs.slice(start, start + specsPerMachine);

console.log(
`Sharding specs manually: machine ${machineIndex}/${machineCount} running ${machineSpecs.length} specs`,
`Sharding specs manually for fork: machine ${machineIndex}/${machineCount} running ${machineSpecs.length} specs`,
);
args.push('--spec', machineSpecs.join(','));
} else {
Expand Down Expand Up @@ -51,9 +52,6 @@ async function runCypress() {
if (tags.length > 0) {
args.push('--tag', tags.join(','));
}

// Enable auto-cancellation to save CI time on failures
args.push('--auto-cancel-after-failures', '3');
}

console.log('Running Cypress with args:', args.join(' '));
Expand Down