fix: emotes in builder mode#52
Merged
Merged
Conversation
Vercel Preview is ready!
|
mihakrajnc
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: emotes in builder mode
Related PRs
Summary
This pull request adds support for controlling and querying emote playback in the Unity wearable preview, including play, pause, seek, stop, and sound controls, as well as communication between Unity and JavaScript for these features. The changes introduce new methods in the emote animation controller, expose them through the JS bridge, and ensure proper state handling and cleanup.
Emote Playback Controls:
Added methods to
EmoteAnimationControllerfor pausing, resuming, seeking (GoToEmote), enabling/disabling sound, and querying emote state (length, playing, paused, has sound). These allow for fine-grained control of emote playback. [1] [2] [3] [4]Updated
PreviewControllerto expose these controls and state queries, delegating toEmoteAnimationController.JS Bridge Integration:
Exposed the new emote control and query methods to JavaScript via
JSBridge, enabling JS to control emote playback and receive state updates from Unity.Implemented corresponding native calls and message handlers in
JSBridge.jslibfor communication between Unity and the browser, including posting emote state updates. [1] [2] [3]Emote State Management and Cleanup:
ClearEmotemethod to bothAvatarLoaderandPreviewController, ensuring proper disposal and state reset when cleaning up emotes. [1] [2]Other Adjustments:
Prevented loading the "idle" emote as an embedded emote, ensuring it is treated as a null emote to avoid fallback to T-pose.
Removed a debug log statement from the emote loading process for cleaner logs.