Skip to content

fix: emotes in builder mode#52

Merged
RocioCM merged 1 commit into
feat/builder-mode-supportfrom
fix/builder-mode-emotes
Apr 6, 2026
Merged

fix: emotes in builder mode#52
RocioCM merged 1 commit into
feat/builder-mode-supportfrom
fix/builder-mode-emotes

Conversation

@RocioCM

@RocioCM RocioCM commented Apr 2, 2026

Copy link
Copy Markdown
Member

fix: emotes in builder mode

Related PRs

Summary

This pull request adds support for controlling and querying emote playback in the Unity wearable preview, including play, pause, seek, stop, and sound controls, as well as communication between Unity and JavaScript for these features. The changes introduce new methods in the emote animation controller, expose them through the JS bridge, and ensure proper state handling and cleanup.

Emote Playback Controls:

  • Added methods to EmoteAnimationController for pausing, resuming, seeking (GoToEmote), enabling/disabling sound, and querying emote state (length, playing, paused, has sound). These allow for fine-grained control of emote playback. [1] [2] [3] [4]

  • Updated PreviewController to expose these controls and state queries, delegating to EmoteAnimationController.

JS Bridge Integration:

  • Exposed the new emote control and query methods to JavaScript via JSBridge, enabling JS to control emote playback and receive state updates from Unity.

  • Implemented corresponding native calls and message handlers in JSBridge.jslib for communication between Unity and the browser, including posting emote state updates. [1] [2] [3]

Emote State Management and Cleanup:

  • Improved emote cleanup by adding a ClearEmote method to both AvatarLoader and PreviewController, ensuring proper disposal and state reset when cleaning up emotes. [1] [2]

Other Adjustments:

  • Prevented loading the "idle" emote as an embedded emote, ensuring it is treated as a null emote to avoid fallback to T-pose.

  • Removed a debug log statement from the emote loading process for cleaner logs.

@RocioCM RocioCM self-assigned this Apr 2, 2026
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown

badge

Vercel Preview is ready!

Field Value
Preview https://aang-renderer-hvugp9xf8-decentraland1.vercel.app
Commit 4854f0adffe93dbed1d9af996a7636248867ae56
Logs https://github.com/decentraland/aang-renderer/actions/runs/23904414294

@RocioCM
RocioCM merged commit e2221bb into feat/builder-mode-support Apr 6, 2026
5 checks passed
@RocioCM
RocioCM deleted the fix/builder-mode-emotes branch April 6, 2026 14:24
@RocioCM RocioCM mentioned this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants