feat: builder mode support#53
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: emotes in builder mode
lorenzo-ranciaffi
requested changes
Apr 9, 2026
lorenzo-ranciaffi
left a comment
lorenzo-ranciaffi
left a comment
Contributor
There was a problem hiding this comment.
Left some comments, looks good otherwise
|
Vercel Preview is ready!
|
lorenzo-ranciaffi
approved these changes
Apr 10, 2026
lorenzo-ranciaffi
left a comment
lorenzo-ranciaffi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing the comments 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces several new features and improvements related to emote playback control and entity parsing, as well as some bug fixes and code cleanup. The main focus is on enhancing emote playback functionality (such as play, pause, seek, and sound control) and improving how base64-encoded entities are handled.
Emote Playback Controls and JS Bridge Integration:
EmoteAnimationController, including play, pause, resume, stop, seek (GoToEmote), enable/disable sound, and methods to query emote state (length, playing, sound presence). These are exposed via the JS bridge for integration with external UI or scripts. [1] [2] [3] [4] [5]OnEmoteLength,OnIsEmotePlaying,OnHasSound) to communicate emote state and control between Unity and the browser environment. [1] [2] [3]Entity and Metadata Parsing Improvements:
RawActiveEntityto properly parse base64-encoded entities, handling both wearables and emotes, and converting them into the standardActiveEntityformat. Updated the logic to distinguish emotes from wearables and fixed issues with empty/null classes. [1] [2]EntityDefinition.FromBase64to use the newRawActiveEntityparsing logic, improving reliability and maintainability.EntityDefinition.FromActiveEntitywhere the thumbnail could throw if not found, now safely handles missing thumbnails.Configuration and Feature Flags:
DisableFaceboolean property toAangConfiguration, including support for setting it via URL parameters, allowing facial features to be toggled on or off. [1] [2]Code Cleanup:
ForBodyShapeRawmethod fromEntityDefinition.These changes collectively improve the flexibility and robustness of emote playback and entity handling, and lay the groundwork for more advanced avatar and emote interactions.