feat: remove GLB extension param reading, use metadata-driven params#58
Closed
decentraland-bot wants to merge 1 commit into
Closed
feat: remove GLB extension param reading, use metadata-driven params#58decentraland-bot wants to merge 1 commit into
decentraland-bot wants to merge 1 commit into
Conversation
Stop reading spring bone parameters from DCL_spring_bone_joint GLTF extension. Detect spring bones by naming convention and use defaults. Actual params arrive via JSBridge setSpringBonesParams from metadata. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Vercel Preview is ready!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GLTFast.SpringBoneJointComponentdependency fromAvatarUtils.cs→BuildSpringBoneData()SpringBone_naming convention with default params at registrationJSBridge.SetSpringBonesParams()→SpringBonesDriver.SetSpringChainsForWearable()pathTest plan
SetSpringBonesParamscorrectly overrides default params at runtimeRequested by Rocío Corral Mena via Slack
🤖 Generated with Claude Code