feat: spring bones#60
Merged
Merged
Conversation
|
Vercel Preview is ready!
|
springBones now read from metadata.data.springBones (was top-level on ActiveEntity) and models keyed by main-file hash (was filename). Vector3 converter accepts both array and object forms. Driver respects isRoot flag and walks chains in skinned.bones order. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Switch from reparenting extras under the live avatar skeleton to keeping spring bones in the wearable hierarchy and snapping the wearable's intermediate parent to the live avatar bone every frame. Run the sim at fixed 60 Hz sub-steps so authored stiffness/drag are framerate-invariant. Restore captured rest rotations in UnregisterAll so re-registration after emote/reload doesn't lock onto stale sim state. Match unity-explorer's chain expansion: only isRoot entries seed chains and tagged children are skipped during descendant collection. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Emotes that animate avatar bone scale (e.g. head-explode) now propagate to spring-bone wearables. Previously scale was aligned only at chain registration so the wearable parent kept its initial scale while the avatar bone grew. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
alejandro-jimenez-dcl
marked this pull request as ready for review
May 5, 2026 13:53
lorenzo-ranciaffi
requested changes
May 6, 2026
lorenzo-ranciaffi
left a comment
lorenzo-ranciaffi
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall, I just left a couple of comments 👍 The most important is the apparent leak, of course
lorenzo-ranciaffi
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.