Skip to content

Conversation

@cyaiox
Copy link
Collaborator

@cyaiox cyaiox commented May 9, 2025

This PR fixes the model scaling issue when entities have a decimal scale.

TODO: Continue researching the re-parenting logic issue

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 9, 2025

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 24a3e5d
Status: ✅  Deploy successful!
Preview URL: https://557dc5b9.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-models-scalation.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/models-scalation/dcl-sdk-7.8.8-14976902381.commit-0ec2951.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/models-scalation/dcl-sdk-commands-7.8.8-14976902381.commit-0ec2951.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/models-scalation/@dcl/inspector/dcl-inspector-7.8.8-14976902381.commit-0ec2951.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/models-scalation-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/models-scalation

@cyaiox cyaiox force-pushed the fix/models-scalation branch from 49087ed to 59c3a3e Compare May 9, 2025 16:17
@cyaiox cyaiox changed the title [WIP] fix: Model scaling fix: Model scaling May 12, 2025
@cyaiox cyaiox marked this pull request as ready for review May 12, 2025 11:34
@cyaiox cyaiox closed this Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants