Auth server recommendations#55
Open
nearnshaw wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following recommendations
Where they landed:
SKILL.md:41-45 — new "Per-Player Synced Entities" subsection with the three rules in compact form.
SKILL.md:127 — new Testing & Debugging bullet mapping the two error signatures to their causes.
server-patterns.md:175-246 — full pattern with code: a getOrCreatePlayerEntity that validates its cache, a restart-reconciliation loop keyed on the playerId field with the < 512 guard and duplicate removal, and the getMutableOrNull system idiom.