chore: pin oddish-action to PR #11 head for node24 validation#542
Open
braianj wants to merge 1 commit into
Open
chore: pin oddish-action to PR #11 head for node24 validation#542braianj wants to merge 1 commit into
braianj wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report for CI Build 26245580434Coverage remained the same at 93.58%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary pin of
decentraland/oddish-actionto the head of decentraland/oddish-action#11 so we can validate the node24 runtime bump on a real publish run before that PR is merged.Change
Single SHA swap in
.github/workflows/build-release.yml(bothSet package.json versionandPublishsteps):decentraland/oddish-action@0074f2d535c43b5c83f136525304a6277166d77fdecentraland/oddish-action@4334287e94bcb192de0c7d841fe80a9faedcf191What we're validating
On the first push to master after this merges, the Build and release run should show:
decentraland/oddish-action.using OIDC (npm Trusted Publishing) — skipping _authToken in .npmrc, OIDC token exchange completes, package lands on npm with a provenance attestation.After validation
Once verified green, the right follow-up is to merge oddish-action#11 and bring this pin back to a master-tracked SHA (or
@masterif that's the repo's convention). I left a comment in the workflow noting this pin points at a PR head.