feat: metamorph and video previews#4100
Merged
Merged
Conversation
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
mihakrajnc
changed the title
pravusjif
approved these changes
Jun 5, 2025
Member
There was a problem hiding this comment.
LGTM, the disposing of the textures should already be handled by the CacheCleaner or the CleanUpMaterialsSystem
Ludmilafantaniella
approved these changes
Jun 9, 2025
Contributor
There was a problem hiding this comment.
✅ Tested on both Windows and Mac.
Scene used for testing:
- Genesis Plaza (-3,-2)
- Rapture Gallery (-88,-64), which contains both animated and static NFTs.
- World scene provided in the PR
squeazer.dcl.eth
- All video previews and image thumbnails loaded correctly.
- Didn’t notice glitches or display issues on either OS.
Looks good to me — approving! 🙌
4100-evid.mp4
4100-evidencia.mp4
mihakrajnc
enabled auto-merge (squash)
June 9, 2025 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This switches the project over to using the MetaMorph (KTX2) converter API for all remote textures. It also adds support for displaying video previews for nft shapes. For example, if the nft's preview / thumbnail is an animation (gif / webp) it will be converted via our media converter and displayed in explorer as a video.
What does this PR change?
Test Instructions
Walk around and look at all nft's and remote images in scenes. They should be displayed correctly.
Find some NFT's in the world that have video previews and make sure they show up. Also ensure that changing the URN at runtime works.
I setup a test world at squeazer.dcl.eth which has one NFT shape and 4 buttons that switch between different nft's (2 image 2 video).
Prerequisites
Test Steps
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.