Remove methods related to Profiles from ViewDependencies #4278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now MVC.ViewDependencies does not depend on DCL.Profiles. Now DCL.Profiles does not depend on DCL.UI.Profiles.Helpers. ProfileNameColorHelper moved from DCL.UI.Profiles.Helpers to DCL.Profiles. Created ProfileRepositoryWrapper class to contain the methods that were previously in ViewDependencies. ViewDependencies has been replaced with the new class everywhere UI utilities provided by ViewDependencies were not being used.
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
…apper as not set The profile picture view was hiding the null reference exception. Now the GenericContextMenu asmdef depends on DCL.UI.Profiles.Helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The ViewDependencies class was conceived as a way to provide views with general UI-related tools, like events, inputs or context menu. It was not meant for giving underground access to data services.
In order to prevent other devs from extending the class with more methods that access data services, this should be fixed as soon as possible. Views should not access data directly unless provided by controllers, although there are cases that overcomplicate things and may suggest to directly provide a reference or delegate to the data provider. If that was the case, that must be something explicit.
What does this PR change?
Test Instructions
Smoke testing in features that use profile pictures.