fix: input missing after jump to player#4317
Merged
Merged
Conversation
Use RealType update and OnNavigationExecuted to trigger chat load (when we load a world, or when we teleport)
fcolarich
approved these changes
Jun 2, 2025
fcolarich
left a comment
fcolarich
left a comment
Contributor
There was a problem hiding this comment.
The underlying issue here is a conflict between the SharedSpaceManager and the WindowStackManager, at some point we need to make them both compatible, but for now this will make it work. We should get both managers working together...
Use RealType update and OnNavigationExecuted to trigger chat load (when we load a world, or when we teleport)
…p' into fix/4193-input-missing-after-jump # Conflicts: # Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs # Explorer/Assets/DCL/PluginSystem/Global/ChatPlugin.cs
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
DafGreco
approved these changes
Jun 6, 2025
DafGreco
left a comment
DafGreco
left a comment
There was a problem hiding this comment.
✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- [ ✔️] Backpack and wearables in world
- [✔️ ] Emotes in world and in backpack
- [ ✔️] Teleport with map/coordinates/Jump In
- [ ✔️] Chat and multiplayer
- [✔️ ] Profile card
- [ ✔️] Skybox
- [✔️ ] Settings
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
input missing after jump to player
When using the Jump In button from a friend's passport (accessed via the Friends tab), the chat panel disappears and the input box is not visible after teleporting.
NOTE: this is a workaround fix and here is the issue for the tech debt to be handled later:
#4317
What does this PR change?
This PR fixes missing chat input box after teleporting to friend
Test Steps
--
NOTE: this works for both teleport to parcel or load the world where friend is
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.