Skip to content

fix: rave mode#4341

Merged
dalkia merged 9 commits into
devfrom
test/rave-mode
Jun 9, 2025
Merged

fix: rave mode#4341
dalkia merged 9 commits into
devfrom
test/rave-mode

Conversation

@dalkia

@dalkia dalkia commented Jun 4, 2025

Copy link
Copy Markdown
Collaborator

Pull Request Description

What does this PR change?

Fixes #4046

Rebuilds the Scene_TexArray.shader. This stops the visual glitch in Mac from occuring

Test Instructions

Test Steps

  1. Repeat the steps in the issue. See that you dont get the visual glitch anymore
  2. Check that the LOD_1 have the same visual fidelity as in Windows

Code Review Reference

Please review our Code Review Standards before submitting.

@dalkia
dalkia requested review from a team as code owners June 4, 2025 16:35
@github-actions

github-actions Bot commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

@dalkia dalkia added the no review Used when no review is needed label Jun 4, 2025

@Ludmilafantaniella Ludmilafantaniella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved
Tested on both Windows and Mac.
On Mac, I followed the known reproduction steps and didn’t experience the glitch or the white flashing issue we had in previous builds.
Also compared LOD1 visuals with production, and both builds loaded the same amount of buildings — no visual differences noticed.
Looks solid from my side! 🎯

Evidence for the testing performed can be found on this thread

@dalkia dalkia changed the title test: rave mode fix: rave mode Jun 9, 2025
@dalkia
dalkia merged commit 6615af3 into dev Jun 9, 2025
2 of 3 checks passed
@dalkia
dalkia deleted the test/rave-mode branch June 9, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge no review Used when no review is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QA] Crash Report | App becomes unresponsive while glitching

3 participants