fix: magician wearable#4348
Merged
Merged
Conversation
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
AlejandroAlvarezMelucciDCL
suggested changes
Jun 5, 2025
AlejandroAlvarezMelucciDCL
left a comment
AlejandroAlvarezMelucciDCL
left a comment
Contributor
There was a problem hiding this comment.
Can we create a ticket to update the Asset Bundle Converter as well? Thanks!
Collaborator
Author
|
anicalbano
approved these changes
Jun 5, 2025
anicalbano
left a comment
anicalbano
left a comment
Collaborator
There was a problem hiding this comment.
🟢 Reviewed by QA and working as expected.
✔️ Spawning avatars have the correct behavior
✔️ Instantiating the avatar which had the conflicted wearable works as expected
✔️ Checked both in current prod and PR build
Quick example:
https://github.com/user-attachments/assets/972d911e-7eed-44d0-9373-0bda42dda703
popuz
approved these changes
Jun 9, 2025
dalkia
enabled auto-merge (squash)
June 9, 2025 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
Fixes #2789
If a wearable comes with a
MeshRendererit will break the rendering of it. This PR destroys theMeshRendererbefore we instantiate it from the asset bundle.I also did some cleanup to unused field
SkinnedMeshRendererfieldTest Instructions
Test Steps
prdurn:decentraland:matic:collections-v2:0x68f49361b0e662b4401beda8d9d3d05128ca2053:10. Check that the magician appearsCode Review Reference
Please review our Code Review Standards before submitting.