Fix: Sometimes profile pictures are not loading properly#4362
Merged
Conversation
ProfilePictureView.SetProfileDataProvider removed, now it is provided in the Setup method along with the rest of dependencies instead of being injected as a separate step, which was error-prone.
QThund
added
1-high
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
lorenzo-ranciaffi
approved these changes
Jun 6, 2025
Ludmilafantaniella
approved these changes
Jun 6, 2025
Contributor
There was a problem hiding this comment.
🟢 Tested on both Windows and Mac
Profile pictures are now loading consistently across panels. I couldn’t reproduce the issue of pictures getting stuck loading — everything seems to be working as expected.
❗ On Windows, there are a few profile pictures that don’t load — they just show a colored background. But Ale mentioned this can happen sometimes and it’s not a blocker for approval.
I checked:
- Nearby
- DMs pictures
- Friends tab
- Request tab
- Gallery info profile pictures
- Friends request and accept flow
- Profile picture on Notifications for friend request
profile.picture.mp4
4362-evidence.mp4
✅ Regressions was performed in order to verify that the normal flow is working as expected:
- ✔️ Backpack and wearables in world
- ✔️ Emotes in world and in backpack
- ✔️ Teleport
- ✔️ Chat and multiplayer
- ✔️ Profile card
- ✔️ Gallery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
When showing a panel that contained profile pictures, they sometimes loaded on time but sometimes they were loading forever (internally, they were failing).
ProfilePictureView.SetProfileDataProvider has been removed, now it is provided in the Setup method along with the rest of dependencies instead of being injected as a separate step, which was error-prone.
Test Instructions
It requires smoke testing in all panels that show profile pictures. They should load as expected.