fix: support multiple unreleased builder emote collections preview#4379
Merged
Conversation
… system so that several collections are supported
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
pravusjif
marked this pull request as ready for review
June 9, 2025 21:38
pravusjif
requested review from
lorux0
and removed request for
QThund and
mikhail-dcl
June 9, 2025 21:39
anicalbano
approved these changes
Jun 10, 2025
anicalbano
left a comment
Collaborator
There was a problem hiding this comment.
✔️ Checked by QA following the indications of the PR:
WITH THE ARGS COLLECTION ID
10.06.2025_07.19.20_REC.mp4
WITHOUT THE ARGS
10.06.2025_07.22.01_REC.mp4
The emotes where checked and are working as expected!
lorux0
approved these changes
Jun 10, 2025
pravusjif
enabled auto-merge (squash)
June 10, 2025 14:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
Currently injecting more than 1 EMOTES unreleased collection through
self-preview-builder-collectionsis not working.WHAT
Refactored to have the builder emotes promise creation in a dedicated system so that several collections are supported
TEST INSTRUCTIONS
lovegrenadewithsound.zip), make sure to upload the.zipfile directly so that it contains all the needed files3062136a-065d-4d94-b28c-f57d6ef04860, make sure you are copying the COLLECTION id, not the ITEM ID from 1 specific item of the collection.self-preview-builder-collectionsapp param injecting YOUR COLLECTION IDs separated by commas, example:MacOS
open Decentraland.app --args --debug --position 100,100 --skip-version-check true --self-preview-builder-collections YOUR-COLLECTION-ID-1-GOES-HERE,YOUR-COLLECTION-ID-2-GOES-HEREWinOS
"C:\Users\[YOUR-USER]\Downloads\Decentraland_windows64\Decentraland.exe" --debug --position 100,100 --skip-version-check true --self-preview-builder-collections YOUR-COLLECTION-ID-1-GOES-HERE,YOUR-COLLECTION-ID-2-GOES-HERE--self-preview-builder-collectionsparameter and confirm that normal emotes you own can be equipped and played with this PRs buildMacOS
open Decentraland.app --args --debug --position 100,100 --skip-version-check trueWinOS
"C:\Users\[YOUR-USER]\Downloads\Decentraland_windows64\Decentraland.exe" --debug --position 100,100 --skip-version-check true