Skip to content

fix: support multiple unreleased builder emote collections preview#4379

Merged
pravusjif merged 5 commits into
devfrom
fix/multiple-builder-emotes-preview
Jun 10, 2025
Merged

fix: support multiple unreleased builder emote collections preview#4379
pravusjif merged 5 commits into
devfrom
fix/multiple-builder-emotes-preview

Conversation

@pravusjif

@pravusjif pravusjif commented Jun 9, 2025

Copy link
Copy Markdown
Member

WHY

Currently injecting more than 1 EMOTES unreleased collection through self-preview-builder-collections is not working.

WHAT

Refactored to have the builder emotes promise creation in a dedicated system so that several collections are supported

TEST INSTRUCTIONS

  • To test you will need to create 2 COLLECTIONS in the emotes builder section of the marketplace at https://decentraland.org/builder/collections/
  • Here I provide 4 test emotes that have to be loaded separately into both collections (put half in one and half in the other):
    • There is 1 emote that has audio (lovegrenadewithsound.zip), make sure to upload the .zip file directly so that it contains all the needed files
    • Put whatever emote details that you want (rarity, category, etc.)
    • test-emotes-props.zip
  • Afterwards take note of their collection IDs which can be found in the URL of your collection, for example it looks like: 3062136a-065d-4d94-b28c-f57d6ef04860, make sure you are copying the COLLECTION id, not the ITEM ID from 1 specific item of the collection.
  1. Download the build from this PR
  2. Open the build with the self-preview-builder-collections app param injecting YOUR COLLECTION IDs separated by commas, example:
    MacOS
    open Decentraland.app --args --debug --position 100,100 --skip-version-check true --self-preview-builder-collections YOUR-COLLECTION-ID-1-GOES-HERE,YOUR-COLLECTION-ID-2-GOES-HERE
    WinOS
    "C:\Users\[YOUR-USER]\Downloads\Decentraland_windows64\Decentraland.exe" --debug --position 100,100 --skip-version-check true --self-preview-builder-collections YOUR-COLLECTION-ID-1-GOES-HERE,YOUR-COLLECTION-ID-2-GOES-HERE
  3. After you enter the virtual world, confirm that when opening the Backpack you see the items from your collection and you can equip/unequip them (give them some time as they are raw GLTFs and may take longer to load).
  4. Confirm that you can close the backpack and play the equipped emotes in your avatar outside the backpack too
  5. Close the build and open it without the --self-preview-builder-collections parameter and confirm that normal emotes you own can be equipped and played with this PRs build
    MacOS
    open Decentraland.app --args --debug --position 100,100 --skip-version-check true
    WinOS
    "C:\Users\[YOUR-USER]\Downloads\Decentraland_windows64\Decentraland.exe" --debug --position 100,100 --skip-version-check true

… system so that several collections are supported
@pravusjif pravusjif self-assigned this Jun 9, 2025
@pravusjif pravusjif added the bug Something isn't working label Jun 9, 2025
@pravusjif pravusjif added the enhancement Enhancement of an existing feature label Jun 9, 2025
@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

@pravusjif pravusjif changed the title fix: unreleased builder emotes preview support for more than 1 simultaneous collection fix: unreleased builder emotes preview support more than 1 collection Jun 9, 2025
@pravusjif
pravusjif marked this pull request as ready for review June 9, 2025 21:38
@pravusjif
pravusjif requested review from a team as code owners June 9, 2025 21:38
@pravusjif pravusjif changed the title fix: unreleased builder emotes preview support more than 1 collection fix: support multiple unreleased builder emote collections preview Jun 9, 2025
@pravusjif
pravusjif requested review from lorux0 and removed request for QThund and mikhail-dcl June 9, 2025 21:39
@pravusjif pravusjif moved this from Todo to With QA / Awaiting Review in Explorer Alpha Jun 9, 2025
@pravusjif
pravusjif removed the request for review from a team June 9, 2025 21:40

@anicalbano anicalbano left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Checked by QA following the indications of the PR:

WITH THE ARGS COLLECTION ID

10.06.2025_07.19.20_REC.mp4

WITHOUT THE ARGS

10.06.2025_07.22.01_REC.mp4

The emotes where checked and are working as expected!

@github-project-automation github-project-automation Bot moved this from With QA / Awaiting Review to In Progress in Explorer Alpha Jun 10, 2025
@pravusjif pravusjif moved this from In Progress to With QA / Awaiting Review in Explorer Alpha Jun 10, 2025
@pravusjif
pravusjif enabled auto-merge (squash) June 10, 2025 14:02
@pravusjif pravusjif added the clean-build Used to trigger clean build on PR label Jun 10, 2025
@pravusjif
pravusjif merged commit 6288631 into dev Jun 10, 2025
10 of 12 checks passed
@pravusjif
pravusjif deleted the fix/multiple-builder-emotes-preview branch June 10, 2025 22:46
@github-project-automation github-project-automation Bot moved this from With QA / Awaiting Review to Done in Explorer Alpha Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working clean-build Used to trigger clean build on PR enhancement Enhancement of an existing feature

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants