chore: removed unused bones in wearables hierarchy #6460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
DafGreco,
NickKhalow and
mikhail-dcl
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
AnsisMalins
approved these changes
Dec 16, 2025
| if (transform.GetComponent<Renderer>() != null) | ||
| return true; | ||
|
|
||
| for (int i = 0; i < transform.childCount; i++) |
Collaborator
There was a problem hiding this comment.
When is this loop needed? You just flattened the hierarchy, so none of the children of wearableRoot will have children, so this loop is not needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
Fix #6396
this pr removes the unused bones game objects from the hierarchy of the wearables asset bundles after the mesh data has been extrapolated by the skinning compute shader.
This reduces the clutter we have in the hierarchy of the ab for wearables, child of each avatar
Test Instructions
This PR removes unused stuff, so it shouldn't have any impact visually, but to make sure we need to do a proper testing with many wearables, verify that wearables are correctly equipped when changed in the backpack.
Check also that other people are rendered as expected and animations don't break wearables in general.
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.