Skip to content

Conversation

@lorenzo-ranciaffi
Copy link
Contributor

@lorenzo-ranciaffi lorenzo-ranciaffi commented Dec 17, 2025

Pull Request Description

Fixes #6315

What does this PR change?

This PR adds a toast message for when you block/unblock a user so that the feedback is always present.

On top of that, it solves the issue of the user context menu staying open after clicking on "Block" making it report the wrong friend status.
This PR also handles the nearby and community chat user states: when you block/unblock someone, the user list now reacts properly hiding/showing the user.
There was also a bug in the community chat: if a blocked user sent a message, you were able to see it. This was caused because the filter was checking the livekit proxy address instead of the real sender.

Test Instructions

Prerequisites

  • you can use two accounts at the same time to speed up things (using the same client)

Test Steps

  1. Test all the repro step described in the linked issue.

Test cases:

  1. blocking/unblocking a user shows a toast message in the top of the screen
  2. block a user from the nearby list -> user must disappear on both ends both in world and from the list. You cannot read their new messages
  3. block a user from the community chat participant -> user must disappear on both ends both in world and from the list. You cannot read their new messages
  4. unblocking someone makes them visible in both nearby and community chat member list (if they are still online)
  5. When you block someone using their context menu, the menu closes after the operation
  6. You can block a user from the community card member list -> the friendship status changes and you no longer see the "block" option from the context menu
  7. Private DMs to a blocked user suggest you to unblock them (on their end, they see you offline)

These should be most of them if not all. If I missed some combination, feel free to add them.

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

@lorenzo-ranciaffi lorenzo-ranciaffi marked this pull request as ready for review December 18, 2025 10:28
@lorenzo-ranciaffi lorenzo-ranciaffi requested review from a team as code owners December 18, 2025 10:28
@lorenzo-ranciaffi lorenzo-ranciaffi moved this from In Progress to With QA / Awaiting Review in Explorer Alpha Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: With QA / Awaiting Review

Development

Successfully merging this pull request may close these issues.

[QA] Block User | No visual feedback after blocking a user

3 participants