Hotfix: social emotes revert #6529
Open
+2,303
−10,090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
Reverts the whole Social Emtoes shapes, in the hope to stabilize emote playing in
mainAdds the backpack fix which caused a race condition while updating the avatar due to a shared
WearablePromiseTest Instructions
Skinning fix
This is the trickest one to reproduce and confirm that is fixed on this PR. The repro steps are
Eventually, skinning should break and avatars should behave strangely like we have been seeing. My recomendation is to try and spend time with the
mainbuild (not the one inprdbut latestmainbranch) and get the error. Its easier to reproduce on low FPS environments, so maybe you can try doing it on the MVMF scenes, with as many as loaded as possible and on higher settings.Once you undertand how its possible to get, come back to this release PR and try again. You should not be able to get it.
Test previous hotfixes issues
Issue 1: Avatar distortion
Issue 2: User moves while frozen on an emote
Issue 3: Avatar of user A not emoting but user B sees it emoting
Retest Audio Analysis
For peace of mind (given that protocol was rebuilt) can we test this PR?
Code Review Reference
Please review our Code Review Standards before submitting.