Chore: adapter for thirdweb http client#7180
Merged
Merged
Conversation
github-actions
Bot
requested review from
DafGreco,
NickKhalow and
mikhail-dcl
and removed request for
DafGreco
February 20, 2026 10:45
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
…dweb-http-client' into chore/otp-email/adapter-for-thirdweb-http-client
|
PR reviewed and approved by QA on both platforms following instructions. ✅ Test Auth 1
Other flows:
Gift
Donations
Note that the test case Auth 2 has been skipped because the ff cannot be turned off. More info here Windows test.2.mp4send.gift.windows.mp4donations.windows.mp4Mac donations.mac.mp4send.gift.mac.mp4 |
balducciv
approved these changes
Feb 20, 2026
mikhail-dcl
requested changes
Feb 23, 2026
mikhail-dcl
left a comment
mikhail-dcl
left a comment
Collaborator
There was a problem hiding this comment.
Overlook looks good, but something in that timeout path doesn't look right
mikhail-dcl
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix #6995
web3 test-scene
What does this PR change?
This PR replaces ThirdWeb http client with our own based on the WebRequestController. Main class to review is
DclThirdwebHttpClient.cs.Additionally it
Test Instructions
Test Auth 1
smoke test on OTP login flow
Test Auth 2
Test meta-transactions
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.