Skip to content

test: --asset-bundles-url override for AB validation (DO NOT MERGE)#8914

Open
LautaroPetaccio wants to merge 2 commits into
devfrom
test/asset-bundles-url-override
Open

test: --asset-bundles-url override for AB validation (DO NOT MERGE)#8914
LautaroPetaccio wants to merge 2 commits into
devfrom
test/asset-bundles-url-override

Conversation

@LautaroPetaccio

Copy link
Copy Markdown
Contributor

⚠️ DO NOT MERGE — testing purposes only

This branch exists solely to produce a build for validating encoder-produced asset bundles in the Explorer (the render check). It is not intended to be merged.

What

Adds a --asset-bundles-url <url> launch argument that overrides the asset-bundle CDN host (manifest and bundle requests). Mirrors the existing --gatekeeper-url override:

  • new flag AppArgsFlags.ASSET_BUNDLES_URL ("asset-bundles-url")
  • threaded MainSceneLoaderGatewayUrlsSourceDecentralandUrlsSource, seeding cache[DecentralandUrl.AssetBundlesCDN] with a STATIC entry
  • optional params (null defaults) → backward-compatible; no behavior change when the arg is absent

Why

Point a build at a staging bucket of encoder-generated bundles and visually validate them, without touching production.

Usage

Launch the player with:

--asset-bundles-url https://<host>

where <host> serves the standard scheme — …/manifest/{entityId}_{platform}.json and …/{AB_VERSION}/{entityId}/{file}.

🤖 Generated with Claude Code

Mirrors the existing gatekeeper-url override: a new AppArgsFlags.ASSET_BUNDLES_URL
flag flows MainSceneLoader -> GatewayUrlsSource -> DecentralandUrlsSource, seeding
cache[AssetBundlesCDN] with a STATIC entry so manifest + bundle requests resolve
against a custom host. Lets a build load encoder-produced bundles from a staging
bucket for render validation. TEST-ONLY, not for merge.
@LautaroPetaccio
LautaroPetaccio requested review from a team as code owners June 7, 2026 21:22
@github-actions
github-actions Bot requested a review from anicalbano June 7, 2026 21:22
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

@m3taphysics

This comment has been minimized.

@m3taphysics

Copy link
Copy Markdown
Contributor

PR #8914, run #27394778781

Builds: Windows change, Windows baseline, macOS change, macOS baseline

How to read this table
  • Each build is measured 3 times. The values are the median, and (min–max) is the lowest and highest of those runs — a wide range means the metric is noisy and small differences are not trustworthy.
  • Δ is Change minus Baseline (a negative Δ means Change is faster).
  • 🟢 faster / 🔴 slower — a real difference: larger than both 3% and the run-to-run range.
  • ⚪ within noise — the difference is smaller than how much the build varies between its own runs, so it cannot be told apart from random variation. Treat it as no change.
  • Exceptions logged — exceptions found in the run logs; more than the baseline is flagged 🔴 even when frame times look fine. The Exception breakdown under each table groups them by the explorer's report category and exception type.
  • A run that logged unusually many exceptions (at least 10 and 5× the median of its build's runs — e.g. a service was down during it) is excluded from all numbers and called out under the table.

Framework 13 i7

Metric Baseline Change Δ Result
Samples 2701 (×3) 2701 (×3)
CPU average 33.3 ms 33.3 ms -0.0 ms ⚪ within noise
CPU 1% worst 33.8 ms (33.7–34.0) 33.7 ms (33.6–33.9) -0.1 ms ⚪ within noise
CPU 0.1% worst 37.1 ms (36.0–37.2) 36.4 ms (35.3–37.1) -0.7 ms ⚪ within noise
GPU average 7.5 ms (7.5–7.6) 7.6 ms (7.5–7.9) 0.0 ms ⚪ within noise
GPU 1% worst 19.7 ms (19.2–20.0) 19.1 ms (18.4–19.5) -0.5 ms ⚪ within noise
GPU 0.1% worst 24.8 ms (24.1–26.8) 24.0 ms (23.3–24.3) -0.7 ms ⚪ within noise
Exceptions logged 6 6 0 ⚪ none new
Exception breakdown
Exception Baseline Change
[ENGINE] NullReferenceException 6 6

@charly-bg charly-bg added clean-build Used to trigger clean build on PR and removed clean-build Used to trigger clean build on PR labels Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants