fix: purge Burst cache after unclean Cloud Build + CI actions node24/SHA pinning#8966
Draft
aixaCode wants to merge 8 commits into
Draft
fix: purge Burst cache after unclean Cloud Build + CI actions node24/SHA pinning#8966aixaCode wants to merge 8 commits into
aixaCode wants to merge 8 commits into
Conversation
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5 tasks
Contributor
|
PR #8966, run #27435436524 Builds: Windows change, Windows baseline, macOS change, macOS baseline How to read this table
Framework 13 i7
Exception breakdown
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
Windows builds have been failing on and off (half of the runs on Jun 10) with a Burst error:
Root cause: when a build gets cancelled while it's uploading its Library cache, the Burst hash-cache files end up truncated, and every following build on that target trips over them. New PR targets can inherit the broken cache too, since it's cloned from the template target. A clean build fixes it, but only for that one target, and it gets poisoned again on the next cancellation. It's not a code issue — the same commit built fine and failed 24s apart on two runs.
The fix: before triggering a build,
build.pychecks the previous build's status on the target. If it wascanceled/unknown(or the target is brand new), it tellsPreExportto deleteLibrary/BurstCacheso Burst regenerates it. Healthy targets keep their warm cache (Burst AOT is ~4.5 min warm).While I was in here I also cleaned up around the workflow:
# Test changecommentTest Instructions
Steps (standard run): N/A — CI/build infrastructure only.
Expected result: N/A
Steps (fresh account): N/A
Expected result: N/A
Automation (if applicable): N/A
Prerequisites
force-buildlabel on this PR (it's a draft)Test Steps
purge_burst_cache=True(Prebuild) and[BURST]: purged restored Library/BurstCache(Unity log).purge_burst_cache=Falseand keep the cache, with bcl.exe time around the usual ~274s.Additional Testing Notes
bcl.exe exited after N msbetween purged and non-purged builds tells us the real cost of a cold Burst cache.Quality Checklist