feat: honor land-on-parcel deep link flag#8997
Conversation
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
|
@claude review |
|
Claude finished @lorenzo-ranciaffi's task in 2m 44s —— View job PR Review: feat: honor land-on-parcel deep link flag
Root-Cause CheckProblem: Deep links have no way to request that the avatar lands at the exact requested parcel rather than the scene's spawn point, which is needed for event-specific jump-in flows. Fix type: ✅ Genuine additive feature. The Blocking IssuesNone found. Non-Blocking Observations
string.Equals(deepLink.ValueOf(AppArgsFlags.LAND_ON_PARCEL), "true", System.StringComparison.OrdinalIgnoreCase);
else
chatTeleporter.TeleportToRealmAsync(realm.Value.Value, token).Forget(); // no position → landOnParcel ignoredCorrect and intentional — without a SummaryThe diff is clean and correct. All changes are fully additive ( REVIEW_RESULT: PASS ✅ |
Changes
land-on-parceldeep-link flag (AppArgsFlags.LAND_ON_PARCEL).DeepLinkHandleparses it and threadslandOnParcelthrough both teleport paths, reusing the already-merged land-on-parcel pipeline:ChatTeleporter.TeleportToParcelAsync(genesis) andTeleportToRealmAsync(world + position)StartParcel→TeleportStartupOperationfalseeverywhere, so existing deep links,/goto, and normal startup behave exactly as before.This is the Explorer side only. The senders (decentraland-ui2 deep-link builder + landing-site What's On) come in separate PRs; until then the flag is a no-op (nothing emits it), so this is safe to merge on its own.
Test plan
decentraland://?position=x,y&land-on-parcel=truelands at the event parcel (running app + cold start).?realm=<world>&position=x,y&land-on-parcel=truelands at the parcel (running app)./gotostill land at the scene spawn point (unchanged).