chore: authentication deep link login

Explorer/Assets/DCL/ApplicationGuards/ApplicationBlocklistGuard/BannedNotificationHandler.cs

@@ -20,7 +20,7 @@ public class BannedNotificationHandler : IDisposable
         private readonly IWeb3IdentityCache identityCache;
         private readonly ModerationDataProvider moderationDataProvider;
         private readonly IMVCManager mvcManager;
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
 
         private CancellationTokenSource cts = new ();
 
@@ -30,7 +30,7 @@ public BannedNotificationHandler(
             IWeb3IdentityCache identityCache,
             ModerationDataProvider moderationDataProvider,
             IMVCManager mvcManager,
-            IWebBrowser webBrowser)
+            UnityAppWebBrowser webBrowser)
         {
             this.webRequestController = webRequestController;
             this.urlsSource = urlsSource;
@@ -47,7 +47,7 @@ public void Dispose() =>
             cts.SafeCancelAndDispose();
 
         private void OnBanWarningNotificationClicked(object[] parameters) =>
-            webBrowser.OpenUrl(urlsSource.Url(DecentralandUrl.SupportLink));
+            webBrowser.OpenUrlMainThreadOnly(urlsSource.Url(DecentralandUrl.SupportLink));
 
         private void OnBannedNotificationClicked(object[] parameters)
         {

Explorer/Assets/DCL/ApplicationGuards/ApplicationBlocklistGuard/BlockedScreenController.cs

@@ -14,12 +14,12 @@ public class BlockedScreenController : ControllerBase<BlockedScreenView, Blocked
     {
         private const string DEFAULT_INFO_TEXT = "Contact Support for more information.";
 
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
         private readonly StringBuilder infoTextBuilder = new ();
 
         public override CanvasOrdering.SortingLayer Layer => CanvasOrdering.SortingLayer.OVERLAY;
 
-        public BlockedScreenController(ViewFactoryMethod viewFactory, IWebBrowser webBrowser) : base(viewFactory)
+        public BlockedScreenController(ViewFactoryMethod viewFactory, UnityAppWebBrowser webBrowser) : base(viewFactory)
         {
             this.webBrowser = webBrowser;
         }
@@ -66,7 +66,7 @@ public override void Dispose()
 
         private void OnSupportClicked()
         {
-            webBrowser.OpenUrl(DecentralandUrl.Help);
+            webBrowser.OpenUrlMainThreadOnly(DecentralandUrl.Help);
         }
 
         private static string FormatRemainingBanTime(string expiresAt)

Explorer/Assets/DCL/ApplicationGuards/ApplicationMinimumSpecsGuard/UI/MinimumSpecsScreenController.cs

@@ -11,7 +11,7 @@ namespace DCL.ApplicationGuards
 {
     public class MinimumSpecsScreenController : ControllerBase<MinimumSpecsScreenView>
     {
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
         private readonly IAnalyticsController analytics;
         private readonly IReadOnlyList<SpecResult> specResult;
         public override CanvasOrdering.SortingLayer Layer => CanvasOrdering.SortingLayer.OVERLAY;
@@ -20,7 +20,7 @@ public class MinimumSpecsScreenController : ControllerBase<MinimumSpecsScreenVie
         private MinimumSpecsTablePresenter specsTablePresenter;
 
         public MinimumSpecsScreenController(ViewFactoryMethod viewFactory,
-            IWebBrowser webBrowser,
+            UnityAppWebBrowser webBrowser,
             IAnalyticsController analytics,
             IReadOnlyList<SpecResult> specResult) : base(viewFactory)
         {
@@ -66,7 +66,7 @@ private void OnContinueClicked()
 
         private void OnReadMoreClicked()
         {
-            webBrowser.OpenUrl(DecentralandUrl.MinimumSpecs);
+            webBrowser.OpenUrlMainThreadOnly(DecentralandUrl.MinimumSpecs);
         }
 
         protected override UniTask WaitForCloseIntentAsync(CancellationToken ct) =>

Explorer/Assets/DCL/ApplicationGuards/ApplicationVersionGuard/ApplicationVersionGuard.cs

@@ -31,9 +31,9 @@ public class ApplicationVersionGuard
         private const string DECENTRALAND_LEGACY_LAUNCHER_MAC_X_64_DMG = "Decentraland Outdated-mac-x64.dmg";
 
         private readonly IWebRequestController webRequestController;
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
 
-        public ApplicationVersionGuard(IWebRequestController webRequestController, IWebBrowser webBrowser)
+        public ApplicationVersionGuard(IWebRequestController webRequestController, UnityAppWebBrowser webBrowser)
         {
             this.webRequestController = webRequestController;
             this.webBrowser = webBrowser;
@@ -89,7 +89,7 @@ private void DownloadLauncher()
             string downloadUrl = $"{GetLauncherDownloadPath()}/{assetName}";
 
             if (!string.IsNullOrEmpty(downloadUrl))
-                webBrowser.OpenUrl(downloadUrl);
+                webBrowser.OpenUrlMainThreadOnly(downloadUrl);
             else
                 ReportHub.LogError(ReportCategory.VERSION_CONTROL, "Failed to get launcher download URL.");
         }

Explorer/Assets/DCL/AuthenticationScreenFlow/AuthenticationScreenController.cs

@@ -52,7 +52,7 @@ public enum AuthStatus
 
         private readonly ICompositeWeb3Provider web3Authenticator;
         private readonly ISelfProfile selfProfile;
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
         private readonly IWeb3IdentityCache storedIdentityProvider;
         private readonly ICharacterPreviewFactory characterPreviewFactory;
         private readonly SplashScreen splashScreen;
@@ -99,7 +99,7 @@ public AuthenticationScreenController(
             ViewFactoryMethod viewFactory,
             ICompositeWeb3Provider web3Authenticator,
             ISelfProfile selfProfile,
-            IWebBrowser webBrowser,
+            UnityAppWebBrowser webBrowser,
             IWeb3IdentityCache storedIdentityProvider,
             ICharacterPreviewFactory characterPreviewFactory,
             SplashScreen splashScreen,
@@ -165,7 +165,7 @@ protected override void OnViewInstantiated()
                 new InitAuthState(viewInstance, installSource),
                 new LoginSelectionAuthState(fsm, viewInstance, this, CurrentState, splashScreen, web3Authenticator, webBrowser, enableEmailOTP),
                 new ProfileFetchingAuthState(fsm, viewInstance, this, CurrentState, selfProfile, storedIdentityProvider),
-                new IdentityVerificationDappAuthState(fsm, viewInstance, this, CurrentState, web3Authenticator),
+                new IdentityVerificationDappDeepLinkAuthState(fsm, viewInstance, this, CurrentState, web3Authenticator),
                 new LobbyForExistingAccountAuthState(fsm, viewInstance, this, splashScreen, CurrentState, characterPreviewController),
                 new LobbyForNewAccountAuthState(fsm, viewInstance, this, CurrentState, characterPreviewController, selfProfile, wearablesProvider, webBrowser, webRequestController, decentralandUrlsSource, profileChangesBus)
             );
@@ -289,7 +289,7 @@ async UniTaskVoid ChangeAccountAsync(CancellationToken ct)
 
         private void OpenSupportUrl()
         {
-            webBrowser.OpenUrl(DecentralandUrl.SupportLink);
+            webBrowser.OpenUrlMainThreadOnly(DecentralandUrl.SupportLink);
             DiscordButtonClicked?.Invoke();
         }
 

Explorer/Assets/DCL/AuthenticationScreenFlow/States/IdentityVerificationDappAuthState.cs → Explorer/Assets/DCL/AuthenticationScreenFlow/States/IdentityVerificationDappDeepLinkAuthState.cs

@@ -1,6 +1,5 @@
 using Cysharp.Threading.Tasks;
 using DCL.Diagnostics;
-using DCL.PerformanceAndDiagnostics;
 using DCL.Utilities;
 using DCL.Web3;
 using DCL.Web3.Authenticators;
@@ -14,25 +13,23 @@
 
 namespace DCL.AuthenticationScreenFlow
 {
-    public class IdentityVerificationDappAuthState : AuthStateBase, IPayloadedState<(LoginMethod method, CancellationToken ct)>
+    public class IdentityVerificationDappDeepLinkAuthState : AuthStateBase, IPayloadedState<(LoginMethod method, CancellationToken ct)>
     {
         private readonly MVCStateMachine<AuthStateBase> machine;
-        private readonly VerificationDappAuthView view;
         private readonly AuthenticationScreenController controller;
         private readonly ReactiveProperty<AuthStatus> currentState;
         private readonly ICompositeWeb3Provider compositeWeb3Provider;
 
         private Exception? loginException;
 
-        public IdentityVerificationDappAuthState(
+        public IdentityVerificationDappDeepLinkAuthState(
             MVCStateMachine<AuthStateBase> machine,
             AuthenticationScreenView viewInstance,
             AuthenticationScreenController controller,
             ReactiveProperty<AuthStatus> currentState,
             ICompositeWeb3Provider compositeWeb3Provider) : base(viewInstance)
         {
             this.machine = machine;
-            view = viewInstance.VerificationDappAuthView;
             this.controller = controller;
             this.currentState = currentState;
             this.compositeWeb3Provider = compositeWeb3Provider;
@@ -49,68 +46,57 @@ public void Enter((LoginMethod method, CancellationToken ct) payload)
 
             controller.CurrentRequestID = string.Empty;
 
+            currentState.Value = AuthStatus.VerificationRequested;
             AuthenticateAsync(payload.method, payload.ct).Forget();
         }
 
         public override void Exit()
         {
-            if (loginException == null)
+            if (loginException != null)
             {
-                view.Hide(OUT);
-
-                // Hide login selection view if still visible (social logins skip the verification step,
-                // so ShowVerification is never called and the login selection view remains active)
-                if (viewInstance.LoginSelectionAuthView.gameObject.activeSelf)
-                    viewInstance.LoginSelectionAuthView.Hide();
-            }
-            else
-            {
-                if (currentState.Value == AuthStatus.VerificationRequested)
-                    view.Hide(SLIDE);
-
                 spanErrorInfo = loginException switch
                 {
-                    OperationCanceledException => new SpanErrorInfo("Login process was cancelled by user"),
-                    SignatureExpiredException ex => new SpanErrorInfo("Web3 signature expired during authentication", ex),
-                    Web3SignatureException ex => new SpanErrorInfo("Web3 signature validation failed", ex),
-                    CodeVerificationException ex => new SpanErrorInfo("Code verification failed during authentication", ex),
-                    Web3Exception ex => new SpanErrorInfo("Connection error during authentication flow", ex),
-                    Exception ex => new SpanErrorInfo("Unexpected error during authentication flow", ex),
+                    OperationCanceledException ex => new SpanErrorInfo("Login process was cancelled by user", ex),
+                    TimeoutException ex => new SpanErrorInfo("Deep-link sign-in timed out waiting for the browser to deliver the signin deep link", ex),
+                    SignatureExpiredException ex => new SpanErrorInfo("Web3 signature expired during deep-link authentication", ex),
+                    Web3SignatureException ex => new SpanErrorInfo("Web3 signature validation failed during deep-link authentication", ex),
+                    DeeplinkSigninRetrievalException ex => new SpanErrorInfo($"Signin identity retrieval failed: {ex.Reason}", ex),
+                    Web3Exception ex => new SpanErrorInfo("Connection error during deep-link authentication flow", ex),
+                    { } ex => new SpanErrorInfo("Unexpected error during deep-link authentication flow", ex),
                 };
 
                 if (loginException is not OperationCanceledException)
                     ReportHub.LogException(loginException, new ReportData(ReportCategory.AUTHENTICATION));
             }
 
             NativeWindowManager.ReleaseTemporaryWindowMode();
-            view.BackButton.onClick.RemoveListener(controller.CancelLoginProcess);
             base.Exit();
         }
 
         private async UniTaskVoid AuthenticateAsync(LoginMethod method, CancellationToken ct)
         {
             try
             {
-                compositeWeb3Provider.VerificationRequired += ShowVerification;
                 IWeb3Identity identity = await compositeWeb3Provider.LoginAsync(LoginPayload.ForDappFlow(method), ct);
+                viewInstance.LoginSelectionAuthView.Hide();
                 machine.Enter<ProfileFetchingAuthState, ProfileFetchingPayload>(new (identity, false, ct));
             }
             catch (OperationCanceledException e)
             {
                 loginException = e;
                 machine.Enter<LoginSelectionAuthState, int>(SLIDE);
             }
-            catch (SignatureExpiredException e)
+            catch (TimeoutException e)
             {
                 loginException = e;
                 machine.Enter<LoginSelectionAuthState, int>(SLIDE);
             }
-            catch (Web3SignatureException e)
+            catch (SignatureExpiredException e)
             {
                 loginException = e;
                 machine.Enter<LoginSelectionAuthState, int>(SLIDE);
             }
-            catch (CodeVerificationException e)
+            catch (Web3SignatureException e)
             {
                 loginException = e;
                 machine.Enter<LoginSelectionAuthState, int>(SLIDE);
@@ -125,32 +111,6 @@ private async UniTaskVoid AuthenticateAsync(LoginMethod method, CancellationToke
                 loginException = e;
                 machine.Enter<LoginSelectionAuthState, ErrorType>(ErrorType.CONNECTION_ERROR);
             }
-            finally
-            {
-                compositeWeb3Provider.VerificationRequired -= ShowVerification;
-            }
-        }
-
-        private void ShowVerification((int code, DateTime expiration, string requestId) data)
-        {
-            compositeWeb3Provider.VerificationRequired -= ShowVerification;
-
-            controller.CurrentRequestID = data.requestId;
-            currentState.Value = AuthStatus.VerificationRequested;
-
-            SentryTransactionNameMapping.Instance.StartSpan(LOADING_TRANSACTION_NAME, new SpanData
-            {
-                SpanName = "CodeVerification",
-                SpanOperation = "auth.code_verification",
-                Depth = STATE_SPAN_DEPTH + 1,
-            });
-
-            // Hide non-interactable Login Screen
-            viewInstance.LoginSelectionAuthView.Hide();
-
-            // Show Verification Screen
-            view.Show(data.code, data.expiration);
-            view.BackButton.onClick.AddListener(controller.CancelLoginProcess);
         }
     }
 }

Explorer/Assets/DCL/AuthenticationScreenFlow/States/LobbyForNewAccountAuthState.cs

@@ -33,7 +33,7 @@ public class LobbyForNewAccountAuthState : AuthStateBase, IPayloadedState<(Profi
         private readonly LobbyForNewAccountAuthView view;
 
         private readonly IWearablesProvider wearablesProvider;
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
         private readonly IWebRequestController webRequestController;
         private readonly IDecentralandUrlsSource decentralandUrlsSource;
         private readonly ProfileChangesBus profileChangesBus;
@@ -57,7 +57,7 @@ public LobbyForNewAccountAuthState(MVCStateMachine<AuthStateBase> fsm,
             AuthenticationScreenCharacterPreviewController characterPreviewController,
             ISelfProfile selfProfile,
             IWearablesProvider wearablesProvider,
-            IWebBrowser webBrowser,
+            UnityAppWebBrowser webBrowser,
             IWebRequestController webRequestController,
             IDecentralandUrlsSource decentralandUrlsSource,
             ProfileChangesBus profileChangesBus) : base(viewInstance)
@@ -161,7 +161,7 @@ private void ReparentCharacterPreview()
         }
 
         private void OpenClickableURL(string url) =>
-            webBrowser.OpenUrl(url);
+            webBrowser.OpenUrlMainThreadOnly(url);
 
         private async UniTask InitializeAvatarAsync()
         {

Explorer/Assets/DCL/AuthenticationScreenFlow/States/LoginSelectionAuthState.cs

@@ -22,13 +22,13 @@ public class LoginSelectionAuthState : AuthStateBase, IState, IPayloadedState<Er
         private readonly ReactiveProperty<AuthStatus> currentState;
         private readonly SplashScreen splashScreen;
         private readonly ICompositeWeb3Provider compositeWeb3Provider;
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
         private readonly bool enableEmailOTP;
 
         public LoginSelectionAuthState(MVCStateMachine<AuthStateBase> machine,
             AuthenticationScreenView viewInstance, AuthenticationScreenController controller,
             ReactiveProperty<AuthStatus> currentState, SplashScreen splashScreen,
-            ICompositeWeb3Provider compositeWeb3Provider, IWebBrowser webBrowser, bool enableEmailOTP) : base(viewInstance)
+            ICompositeWeb3Provider compositeWeb3Provider, UnityAppWebBrowser webBrowser, bool enableEmailOTP) : base(viewInstance)
         {
             view = viewInstance.LoginSelectionAuthView;
 
@@ -174,7 +174,7 @@ private void Login(LoginMethod method)
             currentState.Value = AuthStatus.LoginRequested;
 
             view.SetLoadingSpinnerVisibility(true);
-            machine.Enter<IdentityVerificationDappAuthState, (LoginMethod, CancellationToken)>((method, controller.GetRestartedLoginToken()));
+            machine.Enter<IdentityVerificationDappDeepLinkAuthState, (LoginMethod, CancellationToken)>((method, controller.GetRestartedLoginToken()));
         }
 
         private void OTPLogin()
@@ -202,7 +202,7 @@ private void CloseErrorPopup() =>
             view.ErrorPopupRoot.SetActive(false);
 
         private void RequestAlphaAccess() =>
-            webBrowser.OpenUrl(REQUEST_BETA_ACCESS_LINK);
+            webBrowser.OpenUrlMainThreadOnly(REQUEST_BETA_ACCESS_LINK);
     }
 
     public enum ErrorType

Explorer/Assets/DCL/Backpack/AvatarSection/AvatarController.cs

@@ -15,7 +15,7 @@ public class AvatarController : ISection, IDisposable
     {
         private readonly AvatarView view;
         private readonly RectTransform rectTransform;
-        private readonly IWebBrowser webBrowser;
+        private readonly UnityAppWebBrowser webBrowser;
         private readonly BackpackSlotsController slotsController;
         private readonly CategoriesPresenter categoriesPresenter;
         private readonly OutfitsPresenter outfitsPresenter;
@@ -28,7 +28,7 @@ public class AvatarController : ISection, IDisposable
         private readonly URLParameter marketplaceSourceParam = new ("utm_source", "backpack");
 
         public AvatarController(AvatarView view,
-            IWebBrowser webBrowser,
+            UnityAppWebBrowser webBrowser,
             AvatarSlotView[] slotViews,
             NftTypeIconSO rarityBackgrounds,
             BackpackCommandBus backpackCommandBus,
@@ -77,7 +77,7 @@ private void OnOpenMarketplace()
             urlBuilder.Clear();
             urlBuilder.AppendDomain(URLDomain.FromString(decentralandUrlsSource.Url(DecentralandUrl.Market)));
             urlBuilder.AppendParameter(marketplaceSourceParam);
-            webBrowser.OpenUrl(urlBuilder.Build());
+            webBrowser.OpenUrlMainThreadOnly(urlBuilder.Build());
         }
 
         public void Dispose()