Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/version/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ inputs:
description: 'Formatted version tag. If not set, it uses the latest version tag (v[0-9]*)'
required: false
commit_sha:
description: 'The commit SHA to use for versioning'
required: true
description: 'The commit SHA to use for versioning. Falls back to GITHUB_SHA when omitted.'
required: false
outputs:
latest_version:
description: 'Latest available version tag in repo'
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/auto-assign.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: 'Auto Assign Reviewers'

on:
workflow_dispatch:
pull_request:
types: [opened, ready_for_review]

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-profile-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ jobs:
needs: check-commits
if: needs.check-commits.outputs.should_build == 'true'
outputs:
latest_version: ${{ steps.get_version.outputs.latest_version }}
full_version: ${{ steps.get_version.outputs.short_version }}
# short_version (no commit hash) is what the build consumes as its version
version: ${{ steps.get_version.outputs.short_version }}
tag_version: ${{ steps.get_version.outputs.tag_version }}
steps:
- name: Checkout code
Expand All @@ -76,7 +76,7 @@ jobs:
profile: profile
clean_build: true
cache_strategy: library
version: ${{ needs.get-info.outputs.full_version }}
version: ${{ needs.get-info.outputs.version }}
sentry_enabled: true
is_release_build: false
install_source: launcher
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/build-release-main-page.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,20 @@ name: Create Page Weekly Release

on:
workflow_run:
# workflow_run matches by workflow *name* only — a file path here never
# matches anything.
workflows:
- Unity Cloud Build Release
- .github/workflows/build-release-main.yml
types:
- completed

jobs:
jobs:
get-info:
name: Get Info
if: ${{ github.event.workflow_run.conclusion == 'success' }}
runs-on: ubuntu-latest
timeout-minutes: 5
outputs:
latest_version: ${{ steps.get_version.outputs.latest_version }}
full_version: ${{ steps.get_version.outputs.next_full_version }}
tag_version: ${{ steps.get_version.outputs.next_tag_version }}
steps:
- name: Checkout code
Expand Down Expand Up @@ -65,8 +64,11 @@ jobs:
with:
generate_release_notes: true
draft: true # Swap to auto-release!
# No target_commitish: the tag was created and pushed on main above,
# so the release resolves to it. github.sha here is the DEFAULT
# branch head (dev) — workflow_run events run in that context — and
# must not be used as the release target.
tag_name: ${{ needs.get-info.outputs.tag_version }}
target_commitish: ${{ github.sha }}
files: |
./Decentraland_windows64.zip
./Decentraland_macos.zip
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/build-unitycloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,21 +93,20 @@ on:
- macos-only
workflow_call:
inputs:
# Required inputs carry no default — a default on a required input can
# never be used.
profile:
required: true
type: string
default: 'none'
compression:
required: false
type: string
default: 'LZ4HC'
clean_build:
required: true
default: true
type: boolean
cache_strategy:
required: true
default: 'library'
type: string
version:
required: true
Expand Down Expand Up @@ -314,6 +313,8 @@ jobs:
with:
script: |
const sha = context.payload.pull_request.head.sha;
// Must match this workflow's "Build (<target>)" job names and the
// "Test (<mode>)" job names in test.yml — keep in sync on rename.
const checks = [
'Build (macos)',
'Build (windows64)',
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/claude-pr-review-require.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
name: Require Claude Review
on:
workflow_dispatch:
pull_request:
types: [opened, synchronize, ready_for_review]

Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/claude-pr-review.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
name: Claude Review
on:
workflow_dispatch:
issue_comment:
types: [created]
pull_request_review_comment:
types: [created]
pull_request:
types: [opened, synchronize, ready_for_review, labeled]

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/close-inactive-issues.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ jobs:
close-issues:
runs-on: ubuntu-latest
permissions:
contents: write # Needed to allow deletion of stale state files
issues: write
pull-requests: write

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/enforce-group-approvals.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Enforce QA and DEV Approvals

on:
workflow_dispatch:
pull_request:
branches: [dev]
types:
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/on-delete-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,11 @@ jobs:
DELETED_RELEASE_TAG=$(jq -r .release.tag_name "$GITHUB_EVENT_PATH")
echo "Deleted Release Tag: $DELETED_RELEASE_TAG"

# Fetch the current latest release from the API
LATEST_RELEASE=$(curl -H "Authorization: Bearer $GITHUB_TOKEN" -s "https://api.github.com/repos/${{ github.repository }}/releases/latest" | jq -r .tag_name)
# Fetch the current latest release from the API. '// empty' keeps the
# output blank when no release remains (the API returns 404 JSON with
# no tag_name) — otherwise the literal string "null" would be written
# to latest.json as the version.
LATEST_RELEASE=$(curl -H "Authorization: Bearer $GITHUB_TOKEN" -s "https://api.github.com/repos/${{ github.repository }}/releases/latest" | jq -r '.tag_name // empty')
echo "Latest Release Tag: $LATEST_RELEASE"

echo "latest_release=$LATEST_RELEASE" >> $GITHUB_OUTPUT
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-closure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ jobs:
API_KEY: ${{ secrets.UNITY_CLOUD_API_KEY }}
ORG_ID: ${{ secrets.UNITY_CLOUD_ORG_ID }}
PROJECT_ID: ${{ secrets.UNITY_CLOUD_PROJECT_ID }}
TARGET: t_${{ matrix.target }}
# --delete derives the target names for every platform from BRANCH_NAME
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
run: python -u scripts/cloudbuild/build.py --delete
1 change: 0 additions & 1 deletion .github/workflows/pr-comment-artifact-url.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ on:
- "Unity Cloud Build"
branches-ignore:
- "main"
workflow_dispatch:
permissions:
contents: read
pull-requests: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-comment-delete-artifact-url.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# pr-comment-artifact-url.yml
# pr-comment-delete-artifact-url.yml
---
name: Delete Artifact URL in PR

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/pr-comment-warnings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ on:
- "completed"
workflows:
- "Unity Test"
workflow_dispatch:

permissions:
contents: read
Expand Down
40 changes: 4 additions & 36 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -224,42 +224,7 @@ jobs:
exit 1
fi

# - name: Activate Unity license
# run: |
# docker run --rm \
# -v /tmp/unity-home/.local/share/unity3d:/root/.local/share/unity3d \
# -v /tmp/unity-home/.cache/unity3d:/root/.cache/unity3d \
# -v /tmp/unity-home/.config/unity3d:/root/.config/unity3d \
# -e UNITY_EMAIL="$UNITY_EMAIL" \
# -e UNITY_PASSWORD="$UNITY_PASSWORD" \
# -e UNITY_LICENSE="$UNITY_LICENSE" \
# ${{ steps.img-lint.outputs.ghcr }} \
# /bin/bash -lc 'source /opt/unity/activate.sh 2>/dev/null || true; unity-editor -batchmode -nographics -quit -logFile /dev/stdout'

# # C# Linting using JetBrains ReSharper CLI

# - name: Generate solution inside Unity Docker container
# run: |
# docker run --rm \
# -v "${{ github.workspace }}:/workspace" \
# -v $SSH_AUTH_SOCK:$SSH_AUTH_SOCK \
# -v /tmp/ssh-unity:/root/.ssh:ro \
# -v /tmp/unity-home/.local/share/unity3d:/root/.local/share/unity3d \
# -v /tmp/unity-home/.cache/unity3d:/root/.cache/unity3d \
# -v /tmp/unity-home/.config/unity3d:/root/.config/unity3d \
# -e SSH_AUTH_SOCK=$SSH_AUTH_SOCK \
# -e UNITY_EMAIL="$UNITY_EMAIL" \
# -e UNITY_PASSWORD="$UNITY_PASSWORD" \
# -e UNITY_LICENSE="$UNITY_LICENSE" \
# -w /workspace \
# ${{ steps.img-lint.outputs.ghcr }} \
# unity-editor \
# -batchmode \
# -nographics \
# -projectPath /workspace/Explorer \
# -executeMethod UnityEditor.SyncVS.SyncSolution \
# -quit \
# -logFile -
# BEGIN: C# Linting using JetBrains ReSharper CLI

- name: Rewrite GitHub SSH URLs to HTTPS
run: |
Expand Down Expand Up @@ -466,6 +431,9 @@ jobs:
contains(fromJSON('["force-build", "clean-build"]'), github.event.label.name)
)
)
# The resulting check names "Test (editmode)" / "Test (playmode)" are
# posted as skip statuses by build-unitycloud.yml ("Skip build and test
# checks" step) — keep both places in sync when renaming.
name: Test (${{ matrix.testMode }})
runs-on: ubuntu-latest
strategy:
Expand Down
Loading