-
Notifications
You must be signed in to change notification settings - Fork 17
feat: support scene named spawn points #9369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
popuz
wants to merge
39
commits into
dev
Choose a base branch
from
feat/support-scene-named-spawn-points
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
546f2cc
refactor: extract /goto parsing into pure ChatParamUtils.ParseGotoTa…
popuz 1dc6dc3
feat: land at named spawn point via /goto x,y/name in Genesis
popuz 83c50dc
feat: land at named spawn point via /goto world/name and /goto world/…
popuz a481ed8
add support to /goto-local command
popuz 6006c32
handling spawn point for deep link and app args
popuz 3de989d
add support to /goto-local <spawn point>
popuz c6d57bd
Merge branch 'dev' into feat/support-scene-named-spawn-points
popuz 00363ef
fixed case with same realm
popuz e2142e8
Merge remote-tracking branch 'origin/feat/support-scene-named-spawn-p…
popuz 7df5ed5
Merge branch 'dev' into feat/support-scene-named-spawn-points
popuz 627d6a4
extracted extension and removed exception
popuz 32c3c79
tests and editor linting warning resolution
popuz 69ff543
fixed flacky test
popuz 08c6dd4
Merge branch 'dev' into feat/support-scene-named-spawn-points
popuz 0c78a14
extended PR warning comments
popuz 5019cf2
Merge remote-tracking branch 'origin/feat/support-scene-named-spawn-p…
popuz 3ddf815
fixed 3 warnings
popuz 2c48eda
add Unity extension to linting
popuz 754d4a1
downgraded InspectCode version to be compatible with Rider.Unity plugin
popuz 4d3aa71
fix double package
popuz 804a62a
fixing package duplicate
popuz 940b861
fix crash on exit for linting
popuz 2bd1d9a
fixed ranged spawn points
popuz 8c6fd9d
reverted inspection CI step
popuz 55ffe54
trying with Unity extension but without solution wide analysis
popuz 33e5d28
downgraded ReSharper CLI to 2023 + Rider.Unity
popuz b57099b
removed disabling solution wide analysis (no-swea) parameter
popuz bc8a725
reverted CI steps
popuz 4cb0488
Merge branch 'dev' into feat/support-scene-named-spawn-points
popuz 5cfe5a3
Merge branch 'dev' into feat/support-scene-named-spawn-points
popuz d7940b5
Merge remote-tracking branch 'origin/dev' into feat/support-scene-nam…
popuz 9c6a140
Merge branch 'dev' into feat/support-scene-named-spawn-points
popuz 2c975de
polishing linting error message and more linting fixes
popuz d0265a0
filtered test comments
popuz 84b1782
linting and tests CI check
popuz e6eee03
Merge branch 'dev' into feat/support-scene-named-spawn-points
popuz 1acf112
fied Claude review concerns
popuz adec984
Revert "linting and tests CI check"
popuz a0e1cff
fixing Claude concerns
popuz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| using UnityEngine; | ||
|
|
||
| namespace DCL.Chat.Commands | ||
| { | ||
| /// <summary> | ||
| /// Parsed target of the /goto command, produced by <see cref="ChatParamUtils.ParseGotoTarget" />. | ||
| /// Exactly one shape is set: a Genesis parcel (<see cref="Parcel" />, optionally with | ||
| /// <see cref="SpawnPoint" />), a world (<see cref="World" />, optionally with <see cref="Parcel" /> | ||
| /// and/or <see cref="SpawnPoint" />), or one of the special flags <see cref="IsRandom" /> / <see cref="IsCrowd" />. | ||
| /// </summary> | ||
| public readonly struct GotoTarget | ||
| { | ||
| public readonly string? World; | ||
| public readonly Vector2Int? Parcel; | ||
| public readonly string? SpawnPoint; | ||
| public readonly bool IsRandom; | ||
| public readonly bool IsCrowd; | ||
|
|
||
| public GotoTarget(string? world, Vector2Int? parcel, string? spawnPoint, bool isRandom = false, bool isCrowd = false) | ||
| { | ||
| World = world; | ||
| Parcel = parcel; | ||
| SpawnPoint = spawnPoint; | ||
| IsRandom = isRandom; | ||
| IsCrowd = isCrowd; | ||
| } | ||
| } | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.